Refine ConfigProvider interface - #6788
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: f75592a The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
ℹ️ One minor suggestion inline — otherwise looks solid.
Reviewed changes
loadreturnsOption<Node>— lookup absence is now explicit viaOption.none()rather thanundefined.mapInputas an interface capability — removed the internalProviderStatediscriminated union;nestedandmapInputnow delegate through the provider's ownmapInputmethod instead of pattern-matching on state.- Built-in providers wrapped —
fromEnv,fromUnknown, andfromDirnow wrap return values withOption.fromUndefinedOr. orElseusesOption.isSome— fallback check is now structural rather than truthiness.- Tests restructured — organized into
describeblocks, addedassertMissinghelper, new coverage for layers,fromDotEnvquoting,fromDirerror wrapping,fromUnknowninherited property safety, andmapInputcomposition. - Migration docs and CONFIG.md updated — all references to
undefined/Node | undefinedupdated toOption.none()/Option<Node>.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
| * replaced. The identifier is explicit because the outer JavaScript class name | ||
| * is not available while the `extends` expression is evaluated and may change | ||
| * through renaming or minification. | ||
| * |
Contributor
There was a problem hiding this comment.
This JSDoc addition about identifier appears unrelated to the ConfigProvider changes — it describes Schema.Class behavior. Should this be in a separate PR or dropped from this one?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.