Add Semaphore takeIfAvailable - #6793
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 276e55b The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tim-smart
enabled auto-merge (squash)
July 30, 2026 21:17
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
Semaphore.takeIfAvailableinstance method — acquires the specified number of permits only if they are immediately available, returningEffect<boolean>. Implementation follows the existingtakepattern withinternal.suspendfor lazy evaluation and a synchronous check-and-increment that is safe under cooperative Effect scheduling.- Module-level
Semaphore.takeIfAvailabledual function — matches the signature anddual(2, …)pattern used bytakeandrelease. - Tests — two well-scoped tests covering available and unavailable permit branches, including release and retry, and exercising both curried and uncurried forms of the dual function.
- JSDoc — follows conventions with
@seecross-references totake,release, andwithPermitsIfAvailable.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes since prior review
.changeset/add-semaphore-take-if-available.md— well-formedminorchangeset for the newSemaphore.takeIfAvailableAPI.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Semaphore.takeIfAvailablefor fail-fast manual permit acquisitionValidation
pnpm vitest run packages/effect/test/Semaphore.test.tspnpm --dir packages/effect checkpnpm exec dprint check packages/effect/src/Semaphore.ts packages/effect/test/Semaphore.test.tspnpm exec oxlint -f unix packages/effect/src/Semaphore.ts packages/effect/test/Semaphore.test.tsCloses EFF-235
Closes #6787