Optimize Node HTTP response handling - #6813
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: c091b9b The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- HEAD response idempotency — adds a
completedguard in the HEAD path to prevent doubleresumewhen thecloseevent fires before the.end()callback returns. - Stream chunk coalescing — replaces per-chunk iteration with a single
Buffer.concat+nodeResponse.writecall, eliminating theneedDrainstate machine and its correctness bug (a later successful write in the same batch could clearneedDrainafterdrainLatchwas already closed). - Method caching — caches
toUpperCase()onServerRequestImpl.methodvia??=. - Tests — three well-scoped regression tests covering HEAD completion ordering, chunk coalescing, and backpressure/drain behavior.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ServerRequestImplRoot cause and impact
Streaming batches were written one chunk at a time, and the backpressure loop could clear its drain state after a later successful write. HEAD responses also shared a callback between
closeandendwithout guarding repeated invocation. The updated response path reduces chunked-transfer/writev overhead and keeps response completion state correct.Validation
nix develop -c pnpm test --run packages/platform-node/test/NodeHttpServer.test.ts packages/platform-node/test/HttpApi.test.ts packages/platform-node/test/HttpStaticServer.test.ts packages/platform-node/test/HttpStaticServerConditional.test.ts(88 tests)nix develop -c pnpm checknix develop -c pnpm lint-fixCloses EFF-271