Fix Metric linear boundary spacing - #6821
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 21d90dd The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
ℹ️ One rough edge worth noting — see below.
Reviewed changes
- Bug fix:
linearBoundariesformula changed fromstart + n + widthtostart + n * width, restoring proper linear spacing that matches v3 behavior - Test: Added a focused regression test confirming
{ start: 10, width: 20, count: 5 }→[10, 30, 50, 70, Infinity]— would fail on the old code - JSDoc: Updated inline boundary values in histogram examples; simplified the
linearBoundariesdoctest from a full Effect program to a direct value assertion
ℹ️ Stale v3→v4 migration note
The migration note at migration/v3-to-v4.md:11341 documents the old buggy formula (start + i + width) and instructs users to "Preserve the v3 formula manually when width is not 1." After this fix the v4 behavior matches v3's start + i * width, so the migration note and its workaround advice are now stale — applying the workaround would reintroduce the bug.
Technical details
# Stale migration note
## Affected sites
- `migration/v3-to-v4.md:11341` — documents the old `start + i + width` formula and recommends a manual workaround
## Required outcome
- Update the migration note to reflect that v4 now matches v3 behavior (or remove the formula-specific caveat)DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores interval-based spacing for
Metric.linearBoundariesusingstart + index * width.Adds a focused regression test, corrects affected boundary documentation, and includes a patch changeset.
Validation:
pnpm lintgit diff --check