Add reproduction for Cache issue - #6844
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 1eaf23a The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — a single test added to packages/effect/test/Cache.test.ts reproducing a race condition where an interrupted Cache.get lookup removes a newer value written by an explicit Cache.set.
- Reproduction test for interrupted-lookup-vs-set race: the test forks a
Cache.get, waits for the lookup to start, callsCache.setto overwrite the value, interrupts the getter, then assertsCache.getSuccessreturnsSome(99). Confirmed failing locally — returnsNoneinstead.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — one commit since the prior review (1eaf23a) that applies the fix for the race condition.
- Guarded interrupted-lookup cache cleanup with an identity check: the observer now reads the current entry before removing it on interrupt, and only removes if it is the same
EntryImplthat the lookup created. If aCache.setoverwrote the entry in the meantime, the identity check fails and the newer value is preserved. - Added changeset documenting the fix.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduction only
This PR adds reproduction tests only. No implementation fix is included. CI is expected to fail until the underlying issue is fixed.
Covered audit issues
1.
core-a-f-cache-stale-lookup-removes-set: Stale interrupted lookup removes a newer set valueModule:
CacheExpected contract: set overwrites any existing value for the key, and an older lookup finishing later must not erase that explicit write.
Observed result: Cache.getSuccess returned Option.none() instead of Option.some(99).
Reproduction command: