Add reproduction for TxPubSub issue - #6850
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 8c32aef The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — a single reproduction test added to TxPubSub.test.ts:
publishAll preserves a one-shot iterable across retries— exercises the exact failure mode described in the audit: whenpublishAllruns inside an STM transaction against a bounded hub whose subscriber queue is full, the transaction retries re-iterates the input iterable; a one-shot generator is already exhausted on retry, so the value (2) is silently dropped.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
tim-smart
enabled auto-merge (squash)
August 2, 2026 22:45
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes since the last review (41e300e):
- Implemented the fix —
publishAllnow materializes the input iterable to an array viaArr.fromIterable(values)before entering the STM transaction, so one-shot iterables (generators, streams) are not exhausted on retry. - Updated the reproduction test — added a
hasIteratedhelper for the idle-await loop and theOptionimport for the assertion; the test now passes. - Added changeset —
fix-txpubsub-publish-all-iterables.mdscoped as apatchforeffect.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduction only
This PR adds reproduction tests only. No implementation fix is included. CI is expected to fail until the underlying issue is fixed.
Covered audit issues
1.
core-s-z-testing-tx-pub-sub-publish-all-iterable: publishAll consumes restart-sensitive iterables transactionallyModule:
TxPubSubExpected contract: publishAll accepts any Iterable, and bounded hubs retry until subscriber capacity becomes available without dropping accepted messages.
Observed result: Option.none instead of Option.some(2)
Reproduction command: