Add reproduction for TxQueue issue - #6851
Conversation
🦋 Changeset detectedLatest commit: 9f6eac1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Two reproduction tests for
TxQueue.pollandTxQueue.clearfailing to transition aClosingqueue toDoneafter draining all items
The tests are well-written, follow existing conventions exactly (same it.effect + Effect.tx + Effect.gen pattern, same assertion style), and correctly reproduce the bug described in the PR body. Both poll and clear are missing the Closing → Done state transition that take, takeAll, takeN, and takeBetween already implement.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) | 𝕏
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Source fix for
poll— added aClosing → Donetransition after removing the last item, matching the existing pattern intake,takeN, andtakeBetween. - Source fix for
clear— added aClosing → Donetransition after clearing all items, matching the existing pattern intakeAll. Updated the JSDoc to document the new behavior. - Changeset — added a patch changeset for
effectdescribing the fix.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) | 𝕏
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|

Summary
TxQueue.pollandTxQueue.cleardraining a closing queue.Donewhen either operation removes its final buffered items.effect.Validation
Closes EFF-315