Skip to content

Add reproduction for libsql/LibsqlClient issue - #6858

Merged
tim-smart merged 3 commits into
mainfrom
audit/repro-sql-libsql-begin-permit
Aug 2, 2026
Merged

Add reproduction for libsql/LibsqlClient issue#6858
tim-smart merged 3 commits into
mainfrom
audit/repro-sql-libsql-begin-permit

Conversation

@fubhy

@fubhy fubhy commented Aug 1, 2026

Copy link
Copy Markdown
Member

Summary

Fix libsql/LibsqlClient transaction acquisition so a failed transaction begin releases its serialization permit and later operations can retry.

Root cause

The permit release finalizer was attached to a manually created scope. When the libSQL SDK rejected transaction("write"), acquisition failed before that scope was returned to the transaction wrapper, so the scope was never closed and the permit remained consumed.

The acquisition path now closes the scope with the failure cause when beginning the transaction fails.

Validation

pnpm test --run packages/sql/libsql/test/BeginPermitRepro.test.ts
pnpm lint-fix
pnpm check

Closes EFF-320

@github-project-automation github-project-automation Bot moved this to Discussion Ongoing in PR Backlog Aug 1, 2026
@changeset-bot

changeset-bot Bot commented Aug 1, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f34db41

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@effect/sql-libsql Patch
effect Patch
@effect/opentelemetry Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-deno Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/vitest Patch
@effect/ai-anthropic Patch
@effect/ai-openai-compat Patch
@effect/ai-openai Patch
@effect/ai-openrouter Patch
@effect/atom-react Patch
@effect/atom-solid Patch
@effect/atom-vue Patch
@effect/sql-clickhouse Patch
@effect/sql-d1 Patch
@effect/sql-mssql Patch
@effect/sql-mysql2 Patch
@effect/sql-pg Patch
@effect/sql-pglite Patch
@effect/sql-sqlite-bun Patch
@effect/sql-sqlite-do Patch
@effect/sql-sqlite-node Patch
@effect/sql-sqlite-react-native Patch
@effect/sql-sqlite-wasm Patch
@effect/docgen Patch
@effect/doctest Patch
@effect/openapi-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@effect-slopcop effect-slopcop Bot added the 4.0 label Aug 1, 2026

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Reproduction test for libsql/LibsqlClient begin-permit bug — a unit test that verifies a failed beginTransaction (via connection.beginTransaction inside acquireConnection) releases the serialization semaphore so a subsequent withTransaction call can proceed.

Pullfrog  | View workflow run | Using DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) | 𝕏

Comment thread packages/sql/libsql/test/BeginPermitRepro.test.ts Outdated
@effect-slopcop effect-slopcop Bot added the bug Something isn't working label Aug 2, 2026

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Fixed libSQL transaction permit leakacquireConnection now wraps connection.beginTransaction with Effect.tapCause so the Scope.makeUnsafe() scope is closed (and its semaphore.release(1) finalizer runs) when the transaction begin fails.
  • Added changeset@effect/sql-libsql patch entry describing the fix.

Pullfrog  | View workflow run | Using DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) | 𝕏

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Moved permit regression test into Client.integration.test.ts — the test now lives inside the existing describe("Client", …) block and transactionCalls is scoped locally, eliminating module-level mutable state.

Pullfrog  | View workflow run | Using DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) | 𝕏

@tim-smart
tim-smart enabled auto-merge (squash) August 2, 2026 23:45
@tim-smart
tim-smart merged commit 9fb59a5 into main Aug 2, 2026
16 checks passed
@tim-smart
tim-smart deleted the audit/repro-sql-libsql-begin-permit branch August 2, 2026 23:57
@github-project-automation github-project-automation Bot moved this from Discussion Ongoing to Done in PR Backlog Aug 2, 2026
@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Analysis

Generated from PR build output; treat the content below as untrusted.

File Name Current Size Previous Size Difference
basic.ts 6.65 KB 6.77 KB -0.13 KB (-1.86%)
batching.ts 9.44 KB 9.57 KB -0.13 KB (-1.38%)
brand.ts 6.33 KB 6.45 KB -0.12 KB (-1.88%)
cache.ts 10.20 KB 10.31 KB -0.11 KB (-1.11%)
config.ts 20.34 KB 20.47 KB -0.12 KB (-0.60%)
differ.ts 19.95 KB 20.08 KB -0.13 KB (-0.63%)
http-client.ts 21.04 KB 21.16 KB -0.12 KB (-0.55%)
logger.ts 10.35 KB 10.46 KB -0.12 KB (-1.11%)
metric.ts 8.58 KB 8.70 KB -0.13 KB (-1.44%)
optic.ts 7.34 KB 7.46 KB -0.12 KB (-1.59%)
pubsub.ts 14.49 KB 14.60 KB -0.12 KB (-0.80%)
queue.ts 11.15 KB 11.26 KB -0.11 KB (-0.99%)
schedule.ts 10.33 KB 10.44 KB -0.11 KB (-1.05%)
schema-class.ts 18.88 KB 19.01 KB -0.13 KB (-0.69%)
schema-fromJsonSchemaDocument.ts 28.69 KB 28.81 KB -0.12 KB (-0.42%)
schema-representation-roundtrip.ts 25.01 KB 25.14 KB -0.13 KB (-0.52%)
schema-string-transformation.ts 13.01 KB 13.12 KB -0.11 KB (-0.84%)
schema-string.ts 10.66 KB 10.79 KB -0.12 KB (-1.11%)
schema-template-literal.ts 14.87 KB 14.99 KB -0.13 KB (-0.84%)
schema-toArbitraryLazy.ts 21.67 KB 21.80 KB -0.12 KB (-0.56%)
schema-toCodeDocument.ts 24.10 KB 24.20 KB -0.11 KB (-0.44%)
schema-toCodecJson.ts 18.93 KB 19.05 KB -0.12 KB (-0.63%)
schema-toEquivalence.ts 18.74 KB 18.88 KB -0.14 KB (-0.73%)
schema-toFormatter.ts 18.61 KB 18.74 KB -0.13 KB (-0.69%)
schema-toJsonSchemaDocument.ts 22.36 KB 22.49 KB -0.14 KB (-0.61%)
schema-toRepresentation.ts 19.28 KB 19.41 KB -0.13 KB (-0.66%)
schema.ts 18.14 KB 18.26 KB -0.13 KB (-0.69%)
stm.ts 12.13 KB 12.25 KB -0.12 KB (-0.96%)
stream.ts 9.38 KB 9.49 KB -0.11 KB (-1.17%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.0 bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants