Fix empty snake case conversions - #6859
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 42036ed The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Added reproduction tests — two
it("handles an empty string")tests forsnakeToCamelandsnakeToPascalthat assert empty-string input should return"".
Confirmed both tests fail against current code:
snakeToCamel("")returnsundefined(self[0]on empty string)snakeToPascal("")throwsTypeError: Cannot read properties of undefined (reading 'toUpperCase')
Tests follow existing surrounding patterns and are exactly the assertions needed.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
tim-smart
changed the title
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Added empty-string guards —
snakeToCamelandsnakeToPascalnow return""for empty input viaif (self.length === 0) return selfguards, fixing theundefinedreturn andTypeErrorthe reproduction tests surfaced.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
String.snakeToCamel("")andString.snakeToPascal("")return the empty stringVerification
pnpm test --run packages/effect/test/String.test.tspnpm lintpnpm checkCloses EFF-300