Add reproduction for Trie issue - #6862
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: acc9713 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — a single reproduction test for a Trie.longestPrefixOf bug.
- Reproduction test for sibling-node prefix misattribution —
longestPrefixOfonTrie.make(["a", 1], ["b", 2])with input"c"incorrectly returnsOption.some(["c", 2])instead ofOption.none(), because the algorithm records every valued node it traverses (including siblings reached via left/right comparisons) using the input key slice rather than the actual stored key.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
tim-smart
enabled auto-merge (squash)
August 2, 2026 23:25
tim-smart
force-pushed
the
audit/repro-core-trie-longest-prefix-mismatch
branch
from
August 2, 2026 23:26
f39ea8b to
81063f4
Compare
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — since the prior Pullfrog review, one commit added the fix and a patch changeset.
- Fixed
longestPrefixOfsibling-node prefix misattribution — moved the value-check from before the character comparison into theelse(match) branch, so only nodes whose key matches the current input character are considered candidate prefixes. - Added patch changeset for
effect.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
tim-smart
force-pushed
the
audit/repro-core-trie-longest-prefix-mismatch
branch
from
August 2, 2026 23:57
81063f4 to
4ea3463
Compare
tim-smart
force-pushed
the
audit/repro-core-trie-longest-prefix-mismatch
branch
from
August 2, 2026 23:58
4ea3463 to
acc9713
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Trie.longestPrefixOfso valued sibling nodes are not accepted as prefixeseffectRoot cause
The traversal recorded a node's value before checking whether the current input character matched that node. Values on left or right siblings could therefore be returned as prefixes.
Validation
pnpm test --run packages/effect/test/Trie.test.tspnpm lintpnpm checkCloses EFF-316