Add reproduction for OtlpResource issue - #6865
Merged
tim-smart merged 4 commits intoAug 2, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: e728de5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Two reproduction tests for
OtlpResourcebugs: Adds tests for bigint precision loss inunknownToAttributeValueand missing percent-decoding inOTEL_RESOURCE_ATTRIBUTESparsing. Both tests are expected to fail until the underlying implementation is fixed.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Percent-decoded
OTEL_RESOURCE_ATTRIBUTES:fromConfignow usesSchema.StringFromUriComponentfor both keys and values, matching the OpenTelemetry spec requirement to decode percent-encoded entries. - Preserved bigint precision in
unknownToAttributeValue: ReplacedNumber(value)withString(value)for bigints, avoiding precision loss for values beyondNumber.MAX_SAFE_INTEGER. TheintValuefield inAnyValueis widened tostring | number | null— the protobuf encoder already handlesBigInt(string)correctly. - Added changeset:
effectpatch describing both fixes.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
tim-smart
reviewed
Aug 2, 2026
| @@ -0,0 +1,31 @@ | |||
| import { assert, it } from "@effect/vitest" | |||
Contributor
There was a problem hiding this comment.
Rename this file to OtlpResource.test.ts
tim-smart
enabled auto-merge (squash)
August 2, 2026 23:12
tim-smart
deleted the
audit/repro-unstable-observability-otlpresource-bigint-precision
branch
August 2, 2026 23:50
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OTEL_RESOURCE_ATTRIBUTES.Covered audit issues
1.
unstable-distributed-otlp-resource-attribute-percent-decoding: Resource environment values are not percent-decodedModule:
OtlpResourceExpected contract: OpenTelemetry resource environment parsing must decode percent-encoded keys and values.
Observed result: PASS
Reproduction command:
2.
unstable-distributed-otlp-resource-bigint-precision: Bigint resource attributes lose precisionModule:
OtlpResourceExpected contract: Accepted bigint attributes mapped to OTLP int64 must preserve their integer value.
Observed result: PASS
Reproduction command:
Closes EFF-304