Add reproduction for HttpBody issue - #6866
Merged
tim-smart merged 4 commits intoAug 2, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: f2b2637 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Reproduction test for
HttpBody.fileFromInfocontent-length bug: adds oneit.effecttest that creates a 6-byte file info withbytesToRead: 2, mocks the filesystem to return 2 bytes, and assertscontentLength === bytes.length. Currently fails becausefileFromInfounconditionally usesNumber(info.size)(6) as the content length regardless ofbytesToRead.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
tim-smart
enabled auto-merge (squash)
August 2, 2026 22:50
tim-smart
disabled auto-merge
August 2, 2026 22:50
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Extracted
fileContentLengthhelper: computes the correct content length by subtracting offset from file size and capping atbytesToRead, withMath.max(0, …)guards against negative values. - Fixed
fileandfileFromInfocall sites: both now pass the computed length instead of rawNumber(info.size). - Added audit test for the
fileFromInfooffset + bytesToRead path: creates a 6-byte file info withoffset: 2, bytesToRead: 2, mocks the filesystem, and assertscontentLength === bytes.length. - Added changeset:
"effect": patch, describing the partial‑body content‑length fix.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
tim-smart
reviewed
Aug 2, 2026
| @@ -0,0 +1,14 @@ | |||
| import { assert, it } from "@effect/vitest" | |||
Contributor
There was a problem hiding this comment.
Remove audit from the file name.
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix partial file-backed HTTP bodies so their advertised
contentLengthmatches the bytes selected byoffsetandbytesToRead.Both
HttpBody.fileandHttpBody.fileFromInfonow subtract the offset, cap an explicit read length to the bytes available, and avoid negative content lengths. Previously both constructors always copied the full file size into the body metadata, which could produce an incorrect outgoingContent-Lengthheader.Validation
Closes EFF-305