Add reproduction for LayerMap issue - #6871
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: f39a62d The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Reproduction test for
LayerMap.makepreloadKeys — adds a focusedit.effecttest inLayerMap.test.tsthat creates a map withpreloadKeys: ["a", "b"]and asserts the corresponding layers were built during construction. The test correctly fails because themakeimplementation ignores thepreloadKeysoption at runtime.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
tim-smart
reviewed
Aug 2, 2026
tim-smart
enabled auto-merge (squash)
August 2, 2026 00:53
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Fixed
LayerMap.makeignoring preloadKeys — added the missing runtime options field and a preloading loop that callsRcMap.getfor each key during construction, matching the type-level signature that already propagated the error channel. - Unblocked
fromRecordpreload path — the existingpreload: true → preloadKeys: Object.keys(layers)computation infromRecordwas silently ignored at runtime; now works correctly. - Added changeset — patch-level fix for the
effectpackage.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Applied
Effect.scopedto preload RcMap.get — wrapped eachRcMap.get(rcMap, key)call inEffect.scoped(...)per @tim-smart's suggestion to ensure preloaded entries are properly scoped.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduction only
This PR adds reproduction tests only. No implementation fix is included. CI is expected to fail until the underlying issue is fixed.
Covered audit issues
1.
core-g-r-layermap-preload-options-ignored: LayerMap preload options have no runtime effectModule:
LayerMapExpected contract: Supplying preloadKeys, or preload: true through fromRecord or Service, builds the selected entries while constructing the map and exposes layer failures through the conditional construction error type.
Observed result: The intended failure was reproduced: acquired keys were [] instead of ["a", "b"].
Reproduction command: