Add reproduction for Equal issue - #6874
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: c6ccd50 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
EqualNeverThrows.test.ts: Adds two reproduction tests confirmingEqual.equalsthrows for invalidDatevalues (RangeErrorfromtoISOString()inHash.hash) and forDataViewvalues (TypeErrorfrom iterating a non-iterable in thearray()hash path).
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
effect-slopcop
Bot
added
3.0
tim-smart
reviewed
Aug 2, 2026
| @@ -0,0 +1,15 @@ | |||
| import { assert, describe, it } from "@effect/vitest" | |||
Contributor
There was a problem hiding this comment.
Remove this test file and merge with the main one.
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Date comparison: Switched from
toISOString()togetTime()with a NaN guard, so invalid dates no longer throw. - DataView comparison: Added a
compareDataViewshelper that wraps the DataView buffer inUint8Arraybefore delegating tocompareTypedArrays, with aDataViewinstance-of check to reject mixed-type pairs. - Hash module: Guarded
Date.prototype.toISOString()against NaN and added aDataView-specific branch that wraps the buffer inUint8Arraybefore callingarray(). - Tests: Consolidated reproduction tests into
Equal.test.ts, covering invalid-date equality and DataView byte comparison.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
tim-smart
reviewed
Aug 2, 2026
| return true | ||
| } | ||
|
|
||
| function compareDataViews(self: DataView, that: DataView): boolean { |
Contributor
There was a problem hiding this comment.
Considering this helper is only used in one place in-line it please.
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
This PR adds reproduction tests and fixes the underlying
Equal.equalsandHash.hashhandling for invalid dates andDataViewvalues.Covered audit issues
1.
core-a-f-equal-dataview-throws: DataView comparison throws instead of comparing bytesModule:
EqualExpected contract: Equal.equals deeply compares supported objects and never throws; ArrayBuffer views enter the typed-array comparison path.
Observed result: A direct Node 24 source probe reproduced RangeError for invalid dates and TypeError for DataViews.
Reproduction command:
2.
core-a-f-equal-invalid-date-throws: Invalid dates violate Equal.equals never-throws contractModule:
EqualExpected contract: Equal.equals returns a boolean and never throws, including for JavaScript Date values.
Observed result: A direct Node 24 source probe reproduced RangeError for invalid dates and TypeError for DataViews.
Reproduction command:
Closes EFF-310