Fix aggregateWithin continuation growth - #6877
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: e023325 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
Contributor
There was a problem hiding this comment.
ℹ️ One minor suggestion inline, otherwise looks good.
Reviewed changes
- Lift
Effect.neverandPull.catchDoneout of the recursive schedule loop — the idle schedule tick path no longer rebuilds these continuations on every iteration, preventing unbounded fiber stack growth.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
aggregateWithinschedule recursion inside its innermost continuationDonehandling continuations once around the loopRoot cause
Each idle schedule tick recursively rebuilt the continuations for
Effect.neverandPull.catchDone. Those continuations stayed retained until input arrived, so idleaggregateWithinandgroupedWithinstreams accumulated fiber stack entries indefinitely.Validation
nix develop -c pnpm vitest run packages/effect/test/Stream.test.ts(313 tests passed)nix develop -c pnpm --filter effect checknix develop -c pnpm lintCloses EFF-280
Closes #6826