Skip to content

Add reproduction for Cause issue - #6879

Merged
tim-smart merged 4 commits into
mainfrom
audit/repro-core-cause-map-annotations
Aug 2, 2026
Merged

Add reproduction for Cause issue#6879
tim-smart merged 4 commits into
mainfrom
audit/repro-core-cause-map-annotations

Conversation

@fubhy

@fubhy fubhy commented Aug 1, 2026

Copy link
Copy Markdown
Member

Summary

Fix Cause.map so transforming typed errors preserves annotations attached to Fail reasons.

Root cause

Cause.map rebuilt each mapped Fail reason with only the transformed error, dropping the original reason's annotations. The mapped reason now receives a copy of those annotations while Die and Interrupt reasons continue to pass through unchanged.

Validation

pnpm test --run packages/effect/test/Cause.test.ts packages/effect/test/CauseMapAnnotations.test.ts
pnpm check
pnpm lint

Closes EFF-313

@github-project-automation github-project-automation Bot moved this to Discussion Ongoing in PR Backlog Aug 1, 2026
@changeset-bot

changeset-bot Bot commented Aug 1, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 4f9ffbe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
effect Patch
@effect/opentelemetry Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-deno Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/vitest Patch
@effect/ai-anthropic Patch
@effect/ai-openai-compat Patch
@effect/ai-openai Patch
@effect/ai-openrouter Patch
@effect/atom-react Patch
@effect/atom-solid Patch
@effect/atom-vue Patch
@effect/sql-clickhouse Patch
@effect/sql-d1 Patch
@effect/sql-libsql Patch
@effect/sql-mssql Patch
@effect/sql-mysql2 Patch
@effect/sql-pg Patch
@effect/sql-pglite Patch
@effect/sql-sqlite-bun Patch
@effect/sql-sqlite-do Patch
@effect/sql-sqlite-node Patch
@effect/sql-sqlite-react-native Patch
@effect/sql-sqlite-wasm Patch
@effect/docgen Patch
@effect/doctest Patch
@effect/openapi-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@effect-slopcop effect-slopcop Bot added 4.0 bug Something isn't working labels Aug 1, 2026

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Reproduction test for Cause.map annotation loss — single test in packages/effect/test/CauseMapAnnotations.test.ts that verifies Cause.map preserves annotations on mapped Fail reasons.

The test correctly fails with Service not found: RequestId, confirming the bug. Root cause: causeMap at internal/effect.ts:271 creates new Fail(f(failure.error)) without forwarding failure.annotations.

Pullfrog  | View workflow run | Using DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) | 𝕏

Comment thread packages/effect/src/internal/effect.ts Outdated
@tim-smart
tim-smart enabled auto-merge (squash) August 2, 2026 23:02

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Applied fix to causeMapnew Fail(f(failure.error), failure.annotations) now forwards annotations instead of dropping them, addressing the root cause identified in the prior review.
  • Refined test assertion — changed from Context.get to Context.getOrUndefined per tim-smart's review, a better pattern for this check.
  • Removed unnecessary new Map() wrapping — the 43b70d2c fix initially wrapped annotations in new Map(failure.annotations); the 7e6b7d7 commit applied tim-smart's suggestion to pass failure.annotations directly since it already has the expected type.
  • Added changeset — patch bump for effect.

Pullfrog  | View workflow run | Using DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) | 𝕏

@tim-smart
tim-smart force-pushed the audit/repro-core-cause-map-annotations branch 2 times, most recently from 15717dc to 255cc42 Compare August 2, 2026 23:20

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Removed unnecessary new Map() wrapping in causeMap — passes failure.annotations directly to the Fail constructor instead of copying via new Map().
  • Added explicit ReadonlyMap type annotation to constEmptyAnnotations — fixes type inference so the Fail constructor parameter is ReadonlyMap<string, unknown> rather than Map<string, unknown>, making it directly compatible with failure.annotations from Cause.Fail reasons.

Pullfrog  | View workflow run | Using DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) | 𝕏

@tim-smart
tim-smart force-pushed the audit/repro-core-cause-map-annotations branch from 255cc42 to 4f9ffbe Compare August 2, 2026 23:36
@tim-smart
tim-smart merged commit 3895b9c into main Aug 2, 2026
16 checks passed
@tim-smart
tim-smart deleted the audit/repro-core-cause-map-annotations branch August 2, 2026 23:56
@github-project-automation github-project-automation Bot moved this from Discussion Ongoing to Done in PR Backlog Aug 2, 2026
@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Analysis

Generated from PR build output; treat the content below as untrusted.

File Name Current Size Previous Size Difference
basic.ts 6.65 KB 6.77 KB -0.13 KB (-1.86%)
batching.ts 9.44 KB 9.57 KB -0.13 KB (-1.38%)
brand.ts 6.33 KB 6.45 KB -0.12 KB (-1.88%)
cache.ts 10.20 KB 10.31 KB -0.11 KB (-1.11%)
config.ts 20.35 KB 20.47 KB -0.12 KB (-0.59%)
differ.ts 19.95 KB 20.08 KB -0.12 KB (-0.62%)
http-client.ts 21.04 KB 21.16 KB -0.12 KB (-0.58%)
logger.ts 10.35 KB 10.46 KB -0.12 KB (-1.11%)
metric.ts 8.58 KB 8.70 KB -0.13 KB (-1.44%)
optic.ts 7.34 KB 7.46 KB -0.12 KB (-1.59%)
pubsub.ts 14.49 KB 14.60 KB -0.12 KB (-0.80%)
queue.ts 11.15 KB 11.26 KB -0.11 KB (-0.99%)
schedule.ts 10.33 KB 10.44 KB -0.11 KB (-1.05%)
schema-class.ts 18.89 KB 19.01 KB -0.13 KB (-0.67%)
schema-fromJsonSchemaDocument.ts 28.70 KB 28.81 KB -0.12 KB (-0.41%)
schema-representation-roundtrip.ts 25.01 KB 25.14 KB -0.13 KB (-0.50%)
schema-string-transformation.ts 13.01 KB 13.12 KB -0.11 KB (-0.82%)
schema-string.ts 10.67 KB 10.79 KB -0.12 KB (-1.08%)
schema-template-literal.ts 14.87 KB 14.99 KB -0.12 KB (-0.81%)
schema-toArbitraryLazy.ts 21.68 KB 21.80 KB -0.12 KB (-0.55%)
schema-toCodeDocument.ts 24.10 KB 24.20 KB -0.10 KB (-0.43%)
schema-toCodecJson.ts 18.94 KB 19.05 KB -0.12 KB (-0.61%)
schema-toEquivalence.ts 18.74 KB 18.88 KB -0.13 KB (-0.70%)
schema-toFormatter.ts 18.61 KB 18.74 KB -0.13 KB (-0.68%)
schema-toJsonSchemaDocument.ts 22.36 KB 22.49 KB -0.13 KB (-0.59%)
schema-toRepresentation.ts 19.28 KB 19.41 KB -0.13 KB (-0.64%)
schema.ts 18.14 KB 18.26 KB -0.12 KB (-0.67%)
stm.ts 12.13 KB 12.25 KB -0.12 KB (-0.96%)
stream.ts 9.38 KB 9.49 KB -0.11 KB (-1.17%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.0 bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants