Decode OpenAI-compatible tool parameters - #6882
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 358b32c The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — one commit that mirrors the transformToolCallParams pattern from openai and anthropic into openai-compat, plus two regression tests covering non-streaming and streaming paths.
transformToolCallParams+tryCodecTransform: New helpers that decode JSON-parsed tool arguments through thetoCodecOpenAIcodec — same structure aspackages/ai/openai/src/OpenAiLanguageModel.ts:3100andpackages/ai/anthropic/src/AnthropicLanguageModel.ts:3070.- Two
Schema.Recordregression tests: Non-streaming (generateText) and streaming (streamText) both assert that{ env: [{ 0: "PATH", 1: "/usr/bin" }] }decodes to{ env: { PATH: "/usr/bin" } }.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toCodecOpenAIcodec used to generate provider-facing schemasWhy
OpenAI-compatible providers return tool arguments in the representation described by the transformed JSON Schema. The adapter previously stopped after JSON parsing, so transformed values such as records remained arrays of key/value pairs and failed downstream tool validation. Tool handlers now receive values in their original Effect Schema representation.
Validation
nix develop -c pnpm test packages/ai/openai-compat/test --run(42 tests)nix develop -c pnpm --filter @effect/ai-openai-compat checknix develop -c pnpm exec oxlint -f unix packages/ai/openai-compat/src/OpenAiLanguageModel.ts packages/ai/openai-compat/test/OpenAiLanguageModel.test.tsnix develop -c pnpm exec dprint check packages/ai/openai-compat/src/OpenAiLanguageModel.ts packages/ai/openai-compat/test/OpenAiLanguageModel.test.tsCloses EFF-286
Closes #6818