Propagate ClickHouse result decoding failures as SqlError

[fubhy]

Summary

Transport, body-read, or JSON decoding failures are reported as a successful empty result, making failure indistinguishable from a query that returned no rows.

Important

This PR starts with focused failing reproduction tests. Add the implementation fix to this same branch; CI is expected to fail until that fix is included.

JSON decoding failures become empty query results

Module: clickhouse/ClickhouseClient
Audit ID: sql-adapters-ch-2
Severity / confidence: high / high

What happens

Transport, body-read, or JSON decoding failures are reported as a successful empty result, making failure indistinguishable from a query that returned no rows.

Why it happens

The rejection handler attached to result.json() returns an empty array for every rejection.

Expected behavior

Query transport and result conversion failures must remain observable as SqlError.

Relevant implementation

These links and excerpts are pinned to audit base c9b56ab507f224426ee8388dc450da447ec4715f.

• packages/sql/clickhouse/src/ClickhouseClient.ts:262-274

View problematic code at packages/sql/clickhouse/src/ClickhouseClient.ts:262-274

      private run(sql: string, params: ReadonlyArray<unknown>, format?: Clickhouse.DataFormat) {
        return this.runRaw(sql, params, format).pipe(
          Effect.flatMap((result) => {
            if ("json" in result) {
              return Effect.promise(() =>
                result.json().then(
                  (result) => "data" in result ? result.data : result as any,
                  () => []
                )
              )
            }
            return Effect.succeed([])
          })

View exact lines on GitHub

Reproduction

pnpm test --run packages/sql/clickhouse/test/JsonErrorRepro.test.ts

Observed failure: FAIL: rejected result JSON produced a successful query exit.

Implementation handoff

The initial reproduction tests on this branch are the regression specification for the implementation fix that should follow in this PR.

1. Start with the pinned implementation excerpts and the Why it happens analysis above.
2. Change the implementation so it satisfies the stated Expected behavior; do not weaken or remove the reproduction assertions.
3. Run the focused reproduction command(s) and confirm the observed failures become passing tests:

pnpm test --run packages/sql/clickhouse/test/JsonErrorRepro.test.ts

4. Run the affected package's existing tests, then the repository lint and type checks before requesting review.

Audit provenance

• Audit base: c9b56ab507f224426ee8388dc450da447ec4715f
• Reproduction base: c9b56ab507f224426ee8388dc450da447ec4715f
• Findings: sql-adapters-ch-2
• Initial patch: focused reproduction tests; implementation fix pending

Closes EFF-344

[changeset-bot]

🦋 Changeset detected

Latest commit: 8afe91d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages

Name	Type
@effect/sql-clickhouse	Patch
effect	Patch
@effect/opentelemetry	Patch
@effect/platform-browser	Patch
@effect/platform-bun	Patch
@effect/platform-deno	Patch
@effect/platform-node-shared	Patch
@effect/platform-node	Patch
@effect/vitest	Patch
@effect/ai-anthropic	Patch
@effect/ai-openai-compat	Patch
@effect/ai-openai	Patch
@effect/ai-openrouter	Patch
@effect/atom-react	Patch
@effect/atom-solid	Patch
@effect/atom-vue	Patch
@effect/sql-d1	Patch
@effect/sql-libsql	Patch
@effect/sql-mssql	Patch
@effect/sql-mysql2	Patch
@effect/sql-pg	Patch
@effect/sql-pglite	Patch
@effect/sql-sqlite-bun	Patch
@effect/sql-sqlite-do	Patch
@effect/sql-sqlite-node	Patch
@effect/sql-sqlite-react-native	Patch
@effect/sql-sqlite-wasm	Patch
@effect/docgen	Patch
@effect/doctest	Patch
@effect/openapi-generator	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pullfrog]

ℹ️ No critical issues — one formatting nit inline.

Reviewed changes

A reproduction test for ClickhouseClient that verifies JSON decode errors from query().json() surface as failures rather than being silently swallowed as empty [] results.

• Reproduction test — mocks @clickhouse/client so query().json() rejects with a SyntaxError, creates a client, runs a query, and asserts Exit.isFailure. The test correctly fails with the current code (confirmed locally).

  ^{｜ Fix all ➔ ｜ Fix 👍s ➔ ｜ View workflow run ｜ Using DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏}

[pullfrog]

✅ No new issues found.

Reviewed changes

In this delta since the prior Pullfrog review, the reproduction test was absorbed into the existing classification test file and the implementation fix was added.

• Replaced Effect.promise with Effect.tryPromise in run — the .catch handler wraps JSON decoding failures in SqlError via classifyError, matching the pattern already used for stream/row parse errors.
• Absorbed reproduction test into SqlErrorClassification.test.ts — added resultJsonCause to the shared mock state, clears it in helper functions, and the new test asserts instanceof SqlError, _tag === "UnknownError", and cause preservation.
• Added changeset — @effect/sql-clickhouse patch for propagating result decoding failures as SqlError.

  ^{｜ View workflow run ｜ Using DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏}

[github-actions]

Bundle Size Analysis

Generated from PR build output; treat the content below as untrusted.

File Name	Current Size	Previous Size	Difference
basic.ts	7.06 KB	7.06 KB	0.00 KB (0.00%)
batching.ts	9.86 KB	9.86 KB	0.00 KB (0.00%)
brand.ts	6.34 KB	6.34 KB	0.00 KB (0.00%)
cache.ts	10.62 KB	10.62 KB	0.00 KB (0.00%)
config.ts	20.60 KB	20.60 KB	0.00 KB (0.00%)
differ.ts	20.20 KB	20.20 KB	0.00 KB (0.00%)
http-client.ts	21.49 KB	21.49 KB	0.00 KB (0.00%)
logger.ts	10.76 KB	10.76 KB	0.00 KB (0.00%)
metric.ts	8.99 KB	8.99 KB	0.00 KB (0.00%)
optic.ts	7.18 KB	7.18 KB	0.00 KB (0.00%)
pubsub.ts	14.90 KB	14.90 KB	0.00 KB (0.00%)
queue.ts	11.58 KB	11.58 KB	0.00 KB (0.00%)
schedule.ts	10.74 KB	10.74 KB	0.00 KB (0.00%)
schema-class.ts	19.14 KB	19.14 KB	0.00 KB (0.00%)
schema-fromJsonSchemaDocument.ts	28.96 KB	28.96 KB	0.00 KB (0.00%)
schema-representation-roundtrip.ts	25.29 KB	25.29 KB	0.00 KB (0.00%)
schema-string-transformation.ts	13.30 KB	13.30 KB	0.00 KB (0.00%)
schema-string.ts	10.94 KB	10.94 KB	0.00 KB (0.00%)
schema-template-literal.ts	15.17 KB	15.17 KB	0.00 KB (0.00%)
schema-toArbitraryLazy.ts	21.94 KB	21.94 KB	0.00 KB (0.00%)
schema-toCodeDocument.ts	24.34 KB	24.34 KB	0.00 KB (0.00%)
schema-toCodecJson.ts	19.18 KB	19.18 KB	0.00 KB (0.00%)
schema-toEquivalence.ts	19.01 KB	19.01 KB	0.00 KB (0.00%)
schema-toFormatter.ts	18.87 KB	18.87 KB	0.00 KB (0.00%)
schema-toJsonSchemaDocument.ts	22.60 KB	22.60 KB	0.00 KB (0.00%)
schema-toRepresentation.ts	19.52 KB	19.52 KB	0.00 KB (0.00%)
schema.ts	18.41 KB	18.41 KB	0.00 KB (0.00%)
stm.ts	12.54 KB	12.54 KB	0.00 KB (0.00%)
stream.ts	9.79 KB	9.79 KB	0.00 KB (0.00%)