Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/eff-342-clickhouse-number-binding.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@effect/sql-clickhouse": patch
---

Preserve fractional JavaScript numbers in inferred ClickHouse parameters.
2 changes: 1 addition & 1 deletion packages/sql/clickhouse/src/ClickhouseClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,7 @@ const typeFromUnknown = (value: unknown): string => {
}
switch (typeof value) {
case "number":
return "Decimal"
return "Float64"
case "bigint":
return "Int64"
case "boolean":
Expand Down
11 changes: 9 additions & 2 deletions packages/sql/clickhouse/test/Client.test.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
import { describe, it } from "@effect/vitest"
import { ClickhouseClient } from "@effect/sql-clickhouse"
import { assert, describe, it } from "@effect/vitest"
import { Effect } from "effect"
import * as Statement from "effect/unstable/sql/Statement"

describe("ClickhouseClient", () => {
it("should work", () => {
it("preserves fractional JavaScript numbers in inferred parameters", () => {
const sql = Statement.make(Effect.void as any, ClickhouseClient.makeCompiler(), [], undefined)
const [query] = sql`SELECT ${1.5}`.compile()

assert.strictEqual(query, "SELECT {p1: Float64}")
})
})
Loading