Correct year, ordinal, and meridiem date-mask formatting

[fubhy]

Summary

• render YY date-mask tokens as two-digit years
• use th for the 11th, 12th, and 13th
• label noon and later hours as PM
• keep the regression coverage in the existing Prompt.test.ts file
• add a patch changeset for effect

Validation

• pnpm test --run packages/effect/test/unstable/cli/Prompt.test.ts
• pnpm lint-fix
• pnpm check

Audit provenance

• Audit base: c9b56ab507f224426ee8388dc450da447ec4715f
• Finding: unstable-ai-cli-prompt-date-mask-rendering

Closes EFF-410

[changeset-bot]

🦋 Changeset detected

Latest commit: 927c9c1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages

Name	Type
effect	Patch
@effect/opentelemetry	Patch
@effect/platform-browser	Patch
@effect/platform-bun	Patch
@effect/platform-deno	Patch
@effect/platform-node-shared	Patch
@effect/platform-node	Patch
@effect/vitest	Patch
@effect/ai-anthropic	Patch
@effect/ai-openai-compat	Patch
@effect/ai-openai	Patch
@effect/ai-openrouter	Patch
@effect/atom-react	Patch
@effect/atom-solid	Patch
@effect/atom-vue	Patch
@effect/sql-clickhouse	Patch
@effect/sql-d1	Patch
@effect/sql-libsql	Patch
@effect/sql-mssql	Patch
@effect/sql-mysql2	Patch
@effect/sql-pg	Patch
@effect/sql-pglite	Patch
@effect/sql-sqlite-bun	Patch
@effect/sql-sqlite-do	Patch
@effect/sql-sqlite-node	Patch
@effect/sql-sqlite-react-native	Patch
@effect/sql-sqlite-wasm	Patch
@effect/docgen	Patch
@effect/doctest	Patch
@effect/openapi-generator	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pullfrog]

Important

The regression test is accurate, but the implementation fixes promised by the PR title and commit subject have not been applied to packages/effect/src/unstable/cli/Prompt.ts yet. Merging this branch as-is will fail CI.

Reviewed changes — this run reviewed the single added test in packages/effect/test/unstable/cli/Prompt.test.ts that reproduces the three date-mask rendering bugs identified in the audit.

• Add Prompt.date regression test — exercises YY two-digit year, Do ordinal for day 11, and A meridiem at noon, expecting 24 11th PM.

⚠️ Implementation fixes are missing

The test fails against current HEAD because Prompt.ts still contains all three bugs the PR title claims to correct:

• Year.toString() uses year.substring(-2), which returns the full four-digit year. Use year.slice(-2) instead.
• ordinalIndicator() omits the 11/12/13 exception and renders day 11 as "11st". Return "th" for days 11–13.
• Meridiem.toString() checks getHours() > 12, so noon (hour 12) renders as AM. Use >= 12 instead.

ℹ️ Nitpicks

• The repo convention is to use Clock / TestClock instead of new Date in tests. Consider constructing the fixture through the Effect Clock so the test follows the existing style guide.

  ^{｜ ⚠️ this action is pinned to a commit SHA, which freezes the cleanup step — switch to @v0 or keep the SHA fresh with Dependabot ｜ Fix all ➔ ｜ Fix 👍s ➔ ｜ View workflow run ｜ Using Kimi K2 (free via Pullfrog for OSS) ｜ 𝕏}

[pullfrog]

✅ No new issues found.

Reviewed changes — this run reviewed the second commit 927c9c1, which applies the implementation fixes promised by the PR title on top of the previously-reviewed regression test.

• Applied the three Prompt.ts fixes — switched Year.toString() from substring(-2) to slice(-2), added the 11–13 ordinal exception in ordinalIndicator(), and changed the meridiem check from > 12 to >= 12.
• Updated the regression test fixture — replaced the direct new Date construction with DateTime.makeUnsafe followed by DateTime.toDateUtc, aligning with the repo's preference for DateTime/Clock abstractions in tests.
• Added the patch changeset — .changeset/tidy-dates-smile.md records the effect patch.

The focused Prompt.date test passes locally.

  ^{｜ ⚠️ this action is pinned to a commit SHA, which freezes the cleanup step — switch to @v0 or keep the SHA fresh with Dependabot ｜ View workflow run ｜ Using Kimi K2 (free via Pullfrog for OSS) ｜ 𝕏}

[github-actions]

Bundle Size Analysis

Generated from PR build output; treat the content below as untrusted.

File Name	Current Size	Previous Size	Difference
basic.ts	7.06 KB	7.06 KB	0.00 KB (0.00%)
batching.ts	9.86 KB	9.86 KB	0.00 KB (0.00%)
brand.ts	6.34 KB	6.34 KB	0.00 KB (0.00%)
cache.ts	10.62 KB	10.71 KB	-0.09 KB (-0.83%)
config.ts	20.60 KB	20.60 KB	0.00 KB (0.00%)
differ.ts	20.20 KB	20.20 KB	0.00 KB (0.00%)
http-client.ts	21.49 KB	21.58 KB	-0.09 KB (-0.41%)
logger.ts	10.76 KB	10.84 KB	-0.08 KB (-0.76%)
metric.ts	8.98 KB	8.98 KB	0.00 KB (0.00%)
optic.ts	7.18 KB	7.18 KB	0.00 KB (0.00%)
pubsub.ts	14.90 KB	14.99 KB	-0.09 KB (-0.57%)
queue.ts	11.58 KB	11.66 KB	-0.08 KB (-0.68%)
schedule.ts	10.74 KB	10.83 KB	-0.09 KB (-0.80%)
schema-class.ts	19.14 KB	19.14 KB	0.00 KB (0.00%)
schema-fromJsonSchemaDocument.ts	28.96 KB	28.96 KB	0.00 KB (0.00%)
schema-representation-roundtrip.ts	25.29 KB	25.29 KB	0.00 KB (0.00%)
schema-string-transformation.ts	13.30 KB	13.38 KB	-0.09 KB (-0.64%)
schema-string.ts	10.94 KB	10.94 KB	0.00 KB (0.00%)
schema-template-literal.ts	15.17 KB	15.17 KB	0.00 KB (0.00%)
schema-toArbitraryLazy.ts	21.94 KB	21.94 KB	0.00 KB (0.00%)
schema-toCodeDocument.ts	24.34 KB	24.34 KB	0.00 KB (0.00%)
schema-toCodecJson.ts	19.18 KB	19.18 KB	0.00 KB (0.00%)
schema-toEquivalence.ts	19.01 KB	19.01 KB	0.00 KB (0.00%)
schema-toFormatter.ts	18.87 KB	18.87 KB	0.00 KB (0.00%)
schema-toJsonSchemaDocument.ts	22.60 KB	22.60 KB	0.00 KB (0.00%)
schema-toRepresentation.ts	19.52 KB	19.52 KB	0.00 KB (0.00%)
schema.ts	18.41 KB	18.41 KB	0.00 KB (0.00%)
stm.ts	12.54 KB	12.63 KB	-0.09 KB (-0.74%)
stream.ts	9.80 KB	9.80 KB	0.00 KB (0.00%)