Preserve fractional leading zeros while editing float prompts

[fubhy]

Summary

Typing a fractional value such as 0.05 mutates the edit buffer and submits 5 instead.

Important

This PR starts with focused failing reproduction tests. Add the implementation fix to this same branch; CI is expected to fail until that fix is included.

Float entry drops fractional leading zeros

Module: cli/Prompt
Audit ID: unstable-ai-cli-prompt-float-leading-zero
Severity / confidence: medium / high

What happens

Typing a fractional value such as 0.05 mutates the edit buffer and submits 5 instead.

Why it happens

Each keystroke is parsed and serialized; entering 0.0 is normalized back to 0 before the following digit is appended.

Expected behavior

The float prompt accepts floating-point input before applying configured rounding and validation.

Relevant implementation

These links and excerpts are pinned to audit base c9b56ab507f224426ee8388dc450da447ec4715f.

• packages/effect/src/unstable/cli/Prompt.ts:2861-2883

View problematic code at packages/effect/src/unstable/cli/Prompt.ts:2861-2883

const defaultFloatProcessor = (input: string, state: NumberState) => {
  if (input === "." && state.value.includes(".")) {
    return Effect.succeed(Action.Beep())
  }
  if (state.value.length === 0 && input === "-") {
    return Effect.succeed(Action.NextFrame({
      state: { ...state, value: "-", error: Option.none() }
    }))
  }

  const parsed = Number.parseFloat(state.value + input)
  if (Number.isNaN(parsed)) {
    return Effect.succeed(Action.Beep())
  } else {
    return Effect.succeed(Action.NextFrame({
      state: {
        ...state,
        value: input === "." ? `${parsed}.` : `${parsed}`,
        error: Option.none()
      }
    }))
  }
}

View exact lines on GitHub

Reproduction

pnpm test --run packages/effect/test/unstable/cli/PromptFloatZero.audit.test.ts

Observed failure: FAIL: 0.05 was submitted as 5.

Implementation handoff

The initial reproduction tests on this branch are the regression specification for the implementation fix that should follow in this PR.

1. Start with the pinned implementation excerpts and the Why it happens analysis above.
2. Change the implementation so it satisfies the stated Expected behavior; do not weaken or remove the reproduction assertions.
3. Run the focused reproduction command(s) and confirm the observed failures become passing tests:

pnpm test --run packages/effect/test/unstable/cli/PromptFloatZero.audit.test.ts

4. Run the affected package's existing tests, then the repository lint and type checks before requesting review.

Audit provenance

• Audit base: c9b56ab507f224426ee8388dc450da447ec4715f
• Reproduction base: c9b56ab507f224426ee8388dc450da447ec4715f
• Findings: unstable-ai-cli-prompt-float-leading-zero
• Initial patch: focused reproduction tests; implementation fix pending

Closes EFF-412

[changeset-bot]

🦋 Changeset detected

Latest commit: 9885caf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages

Name	Type
effect	Patch
@effect/opentelemetry	Patch
@effect/platform-browser	Patch
@effect/platform-bun	Patch
@effect/platform-deno	Patch
@effect/platform-node-shared	Patch
@effect/platform-node	Patch
@effect/vitest	Patch
@effect/ai-anthropic	Patch
@effect/ai-openai-compat	Patch
@effect/ai-openai	Patch
@effect/ai-openrouter	Patch
@effect/atom-react	Patch
@effect/atom-solid	Patch
@effect/atom-vue	Patch
@effect/sql-clickhouse	Patch
@effect/sql-d1	Patch
@effect/sql-libsql	Patch
@effect/sql-mssql	Patch
@effect/sql-mysql2	Patch
@effect/sql-pg	Patch
@effect/sql-pglite	Patch
@effect/sql-sqlite-bun	Patch
@effect/sql-sqlite-do	Patch
@effect/sql-sqlite-node	Patch
@effect/sql-sqlite-react-native	Patch
@effect/sql-sqlite-wasm	Patch
@effect/docgen	Patch
@effect/doctest	Patch
@effect/openapi-generator	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pullfrog]

Important

The reproduction test added by this PR currently fails because the implementation fix it describes has not yet been included.

Reviewed changes

• Added one regression test in packages/effect/test/unstable/cli/Prompt.test.ts for Prompt.float to verify that typing 0.05 submits 0.05 instead of 5.

The new test is a sound, minimal regression spec: it exercises the exact keystroke sequence described in the PR body and asserts the precise numeric result. I ran it locally and confirmed it fails against the current defaultFloatProcessor implementation with AssertionError: expected 5 to equal 0.05, which matches the documented failure mode.

Because the PR body states the implementation fix should follow on this same branch and CI is expected to fail until then, this is not mergeable yet. Once the source fix lands and this test passes, the PR will be ready for another look.

  ^{｜ ⚠️ this action is pinned to a commit SHA, which freezes the cleanup step — switch to @v0 or keep the SHA fresh with Dependabot ｜ Fix all ➔ ｜ Fix 👍s ➔ ｜ View workflow run ｜ Using Kimi K2 (free via Pullfrog for OSS) ｜ 𝕏}

[pullfrog]

✅ No new issues found.

Reviewed changes

• Implemented the defaultFloatProcessor fix in packages/effect/src/unstable/cli/Prompt.ts so fractional leading zeros are preserved when the edit buffer already contains a decimal point and the next input is a digit.
• Added a changeset describing the bug fix.
• Verified the regression test added in the prior commit now passes, and the existing Prompt.float tests continue to pass.

The new implementation is minimal and targeted: it avoids re-serializing the parsed number when the user is typing the fractional part, while still falling back to the parsed string for all other inputs (including sign, decimal point insertion, and backspace-driven updates).

  ^{｜ ⚠️ this action is pinned to a commit SHA, which freezes the cleanup step — switch to @v0 or keep the SHA fresh with Dependabot ｜ View workflow run ｜ Using Kimi K2 (free via Pullfrog for OSS) ｜ 𝕏}

[github-actions]

Bundle Size Analysis

Generated from PR build output; treat the content below as untrusted.

File Name	Current Size	Previous Size	Difference
basic.ts	7.06 KB	7.06 KB	0.00 KB (0.00%)
batching.ts	9.86 KB	9.86 KB	0.00 KB (0.00%)
brand.ts	6.34 KB	6.34 KB	0.00 KB (0.00%)
cache.ts	10.62 KB	10.71 KB	-0.09 KB (-0.83%)
config.ts	20.60 KB	20.60 KB	0.00 KB (0.00%)
differ.ts	20.20 KB	20.20 KB	0.00 KB (0.00%)
http-client.ts	21.49 KB	21.58 KB	-0.09 KB (-0.41%)
logger.ts	10.76 KB	10.84 KB	-0.08 KB (-0.76%)
metric.ts	8.98 KB	8.98 KB	0.00 KB (0.00%)
optic.ts	7.18 KB	7.18 KB	0.00 KB (0.00%)
pubsub.ts	14.90 KB	14.99 KB	-0.09 KB (-0.57%)
queue.ts	11.58 KB	11.66 KB	-0.08 KB (-0.68%)
schedule.ts	10.74 KB	10.83 KB	-0.09 KB (-0.80%)
schema-class.ts	19.14 KB	19.14 KB	0.00 KB (0.00%)
schema-fromJsonSchemaDocument.ts	28.96 KB	28.96 KB	0.00 KB (0.00%)
schema-representation-roundtrip.ts	25.29 KB	25.29 KB	0.00 KB (0.00%)
schema-string-transformation.ts	13.30 KB	13.38 KB	-0.09 KB (-0.64%)
schema-string.ts	10.94 KB	10.94 KB	0.00 KB (0.00%)
schema-template-literal.ts	15.17 KB	15.17 KB	0.00 KB (0.00%)
schema-toArbitraryLazy.ts	21.94 KB	21.94 KB	0.00 KB (0.00%)
schema-toCodeDocument.ts	24.34 KB	24.34 KB	0.00 KB (0.00%)
schema-toCodecJson.ts	19.18 KB	19.18 KB	0.00 KB (0.00%)
schema-toEquivalence.ts	19.01 KB	19.01 KB	0.00 KB (0.00%)
schema-toFormatter.ts	18.87 KB	18.87 KB	0.00 KB (0.00%)
schema-toJsonSchemaDocument.ts	22.60 KB	22.60 KB	0.00 KB (0.00%)
schema-toRepresentation.ts	19.52 KB	19.52 KB	0.00 KB (0.00%)
schema.ts	18.41 KB	18.41 KB	0.00 KB (0.00%)
stm.ts	12.54 KB	12.63 KB	-0.09 KB (-0.74%)
stream.ts	9.80 KB	9.80 KB	0.00 KB (0.00%)