Persist permanent entries in KVS setMany operations

[fubhy]

Summary

KVS setMany silently skips every entry without a finite TTL, so values requested as permanent are absent immediately after the operation succeeds.

Important

This PR starts with focused failing reproduction tests. Add the implementation fix to this same branch; CI is expected to fail until that fix is included.

KVS setMany skips permanent entries

Module: Persistence
Audit ID: unstable-state-p-1
Severity / confidence: high / high

What happens

KVS setMany silently skips every entry without a finite TTL, so values requested as permanent are absent immediately after the operation succeeds.

Why it happens

unsafeTtlToExpires returns null for an undefined TTL, but the setMany loop treats null as a reason to return Effect.void instead of writing the permanent entry.

Expected behavior

BackingPersistenceStore.setMany has the same persistence semantics as repeated set calls, and an undefined TTL means no expiration.

Relevant implementation

These links and excerpts are pinned to audit base c9b56ab507f224426ee8388dc450da447ec4715f.

• packages/effect/src/unstable/persistence/Persistence.ts:1094-1100

View problematic code at packages/effect/src/unstable/persistence/Persistence.ts:1094-1100

          setMany: (entries) =>
            Effect.forEach(entries, ([key, value, ttl]) => {
              const expires = unsafeTtlToExpires(clock, ttl)
              if (expires === null) return Effect.void
              const encoded = JSON.stringify([value, expires])
              return store.set(key, encoded)
            }, { concurrency: "unbounded", discard: true }).pipe(

View exact lines on GitHub

Reproduction

pnpm test --run packages/effect/test/unstable/persistence/KeyValueStore.test.ts

Observed failure: get("key") returned undefined after permanent setMany completed.

Implementation handoff

The initial reproduction tests on this branch are the regression specification for the implementation fix that should follow in this PR.

1. Start with the pinned implementation excerpts and the Why it happens analysis above.
2. Change the implementation so it satisfies the stated Expected behavior; do not weaken or remove the reproduction assertions.
3. Run the focused reproduction command(s) and confirm the observed failures become passing tests:

pnpm test --run packages/effect/test/unstable/persistence/KeyValueStore.test.ts

4. Run the affected package's existing tests, then the repository lint and type checks before requesting review.

Audit provenance

• Audit base: c9b56ab507f224426ee8388dc450da447ec4715f
• Reproduction base: c9b56ab507f224426ee8388dc450da447ec4715f
• Findings: unstable-state-p-1
• Initial patch: focused reproduction tests; implementation fix pending

Closes EFF-440

[changeset-bot]

🦋 Changeset detected

Latest commit: ad3a2cf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages

Name	Type
effect	Patch
@effect/opentelemetry	Patch
@effect/platform-browser	Patch
@effect/platform-bun	Patch
@effect/platform-deno	Patch
@effect/platform-node-shared	Patch
@effect/platform-node	Patch
@effect/vitest	Patch
@effect/ai-anthropic	Patch
@effect/ai-openai-compat	Patch
@effect/ai-openai	Patch
@effect/ai-openrouter	Patch
@effect/atom-react	Patch
@effect/atom-solid	Patch
@effect/atom-vue	Patch
@effect/sql-clickhouse	Patch
@effect/sql-d1	Patch
@effect/sql-libsql	Patch
@effect/sql-mssql	Patch
@effect/sql-mysql2	Patch
@effect/sql-pg	Patch
@effect/sql-pglite	Patch
@effect/sql-sqlite-bun	Patch
@effect/sql-sqlite-do	Patch
@effect/sql-sqlite-node	Patch
@effect/sql-sqlite-react-native	Patch
@effect/sql-sqlite-wasm	Patch
@effect/docgen	Patch
@effect/doctest	Patch
@effect/openapi-generator	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pullfrog]

Caution

This PR currently contains only the regression test; the implementation fix is missing, so the added test fails. Do not merge until setMany is updated to persist entries with an undefined TTL.

Reviewed changes — This is a focused bug-fix PR for the KVS-backed persistence layer. The change adds a regression test covering BackingPersistenceStore.setMany with an undefined TTL, and the PR description instructs that the implementation fix should be added to the same branch.

• Added a failing regression test in packages/effect/test/unstable/persistence/KeyValueStore.test.ts that asserts permanent entries survive setMany.

  ^{｜ ⚠️ this action is pinned to a commit SHA, which freezes the cleanup step — switch to @v0 or keep the SHA fresh with Dependabot ｜ Fix all ➔ ｜ Fix 👍s ➔ ｜ View workflow run ｜ Using Kimi K2 (free via Pullfrog for OSS) ｜ 𝕏}

[pullfrog]

✅ No new issues found.

Reviewed changes — The new commit since the prior Pullfrog review adds the implementation fix for KVS-backed setMany.

• Fixed packages/effect/src/unstable/persistence/Persistence.ts so layerBackingKvs.setMany persists entries with an undefined TTL instead of skipping them.
• Added .changeset/quick-kiwis-remember.md describing the patch.
• Confirmed the previously added regression test now passes.

The fix is minimal and aligns setMany behavior with the existing set path: both encode permanent entries as [value, null].

  ^{｜ ⚠️ this action is pinned to a commit SHA, which freezes the cleanup step — switch to @v0 or keep the SHA fresh with Dependabot ｜ View workflow run ｜ Using Kimi K2 (free via Pullfrog for OSS) ｜ 𝕏}

[tim-smart]

Can we move this into the shared test suite

[github-actions]

Bundle Size Analysis

Generated from PR build output; treat the content below as untrusted.

File Name	Current Size	Previous Size	Difference
basic.ts	7.06 KB	7.06 KB	0.00 KB (0.00%)
batching.ts	9.86 KB	9.86 KB	0.00 KB (0.00%)
brand.ts	6.34 KB	6.34 KB	0.00 KB (0.00%)
cache.ts	10.71 KB	10.71 KB	0.00 KB (0.00%)
config.ts	20.60 KB	20.60 KB	0.00 KB (0.00%)
differ.ts	20.20 KB	20.20 KB	0.00 KB (0.00%)
http-client.ts	21.53 KB	21.53 KB	0.00 KB (0.00%)
logger.ts	10.84 KB	10.84 KB	0.00 KB (0.00%)
metric.ts	8.98 KB	8.98 KB	0.00 KB (0.00%)
optic.ts	7.18 KB	7.18 KB	0.00 KB (0.00%)
pubsub.ts	14.99 KB	14.99 KB	0.00 KB (0.00%)
queue.ts	11.66 KB	11.66 KB	0.00 KB (0.00%)
schedule.ts	10.83 KB	10.83 KB	0.00 KB (0.00%)
schema-class.ts	19.14 KB	19.14 KB	0.00 KB (0.00%)
schema-fromJsonSchemaDocument.ts	28.96 KB	28.96 KB	0.00 KB (0.00%)
schema-representation-roundtrip.ts	25.29 KB	25.29 KB	0.00 KB (0.00%)
schema-string-transformation.ts	13.38 KB	13.38 KB	0.00 KB (0.00%)
schema-string.ts	10.94 KB	10.94 KB	0.00 KB (0.00%)
schema-template-literal.ts	15.17 KB	15.17 KB	0.00 KB (0.00%)
schema-toArbitraryLazy.ts	21.94 KB	21.94 KB	0.00 KB (0.00%)
schema-toCodeDocument.ts	24.34 KB	24.34 KB	0.00 KB (0.00%)
schema-toCodecJson.ts	19.18 KB	19.18 KB	0.00 KB (0.00%)
schema-toEquivalence.ts	19.01 KB	19.01 KB	0.00 KB (0.00%)
schema-toFormatter.ts	18.87 KB	18.87 KB	0.00 KB (0.00%)
schema-toJsonSchemaDocument.ts	22.60 KB	22.60 KB	0.00 KB (0.00%)
schema-toRepresentation.ts	19.52 KB	19.52 KB	0.00 KB (0.00%)
schema.ts	18.41 KB	18.41 KB	0.00 KB (0.00%)
stm.ts	12.63 KB	12.63 KB	0.00 KB (0.00%)
stream.ts	9.80 KB	9.80 KB	0.00 KB (0.00%)

[pullfrog]

✅ No new issues found.

Reviewed changes — The new commit since the prior Pullfrog review moves the regression test into the shared testLayer helper.

• Refactored the KVS setMany permanent-entry test from a standalone describe("Persistence / layerBackingKvs") block into testLayer, so every backing layer in the file exercises the same assertion surface.
• Cleaned up the test imports (Layer is now a type-only import, unused assert removed).

The implementation fix in Persistence.ts (layerBackingKvs.setMany no longer skips undefined-TTL entries) and the changeset remain unchanged. The focused test command passes.

  ^{｜ ⚠️ this action is pinned to a commit SHA, which freezes the cleanup step — switch to @v0 or keep the SHA fresh with Dependabot ｜ View workflow run ｜ Using Kimi K2 (free via Pullfrog for OSS) ｜ 𝕏}