Respect zero Node socket open timeouts

.changeset/zero-node-socket-timeout.md

@@ -0,0 +1,5 @@
+---
+"@effect/platform-node-shared": patch
+---
+
+Respect zero-duration open timeouts when opening Node sockets.

packages/platform/node-shared/src/NodeSocket.ts

@@ -135,7 +135,7 @@ export const fromDuplex = <RO>(
           })
         )
         conn = yield* Scope.provide(open, scope).pipe(
-          options?.openTimeout ?
+          options?.openTimeout !== undefined ?
             Effect.timeoutOrElse({
               duration: options.openTimeout,
               orElse: () =>

packages/platform/node/test/NodeSocket.test.ts

@@ -79,6 +79,19 @@ describe("Socket", () => {
       assert.strictEqual(output, "HelloWorld")
     }))
 
+  it.live("respects a zero open timeout", () =>
+    Effect.gen(function*() {
+      const socket = yield* NodeSocket.fromDuplex(Effect.never, { openTimeout: 0 })
+      const error = yield* socket.runRaw(() => {}).pipe(
+        Effect.flip,
+        Effect.timeout("1 second")
+      )
+      assert.strictEqual(error.reason._tag, "SocketOpenError")
+      if (error.reason._tag === "SocketOpenError") {
+        assert.strictEqual(error.reason.kind, "Timeout")
+      }
+    }))
+
   describe("WebSocket", () => {
     const url = `ws://localhost:1234`