fix(Stream): preserve large source chunks when rechunking - #7655
Merged
Conversation
🦋 Changeset detectedLatest commit: 8648481 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
tim-smart
reviewed
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
Stream.rechunkused an array spread when buffering a source chunk. Large chunks can exceed the JavaScript engine's call-argument limit, causing aRangeErrorinstead of preserving the stream elements.The buffering branch now appends values individually. Regression coverage includes larger, equal, and smaller target sizes, plus input split across source chunks. The split case buffers one value before appending a 200,000-element chunk, so it exercises the same known failing size as the primary regression.
This PR also includes a patch changeset for
effect.Verification
nix develop -c pnpm test --run --project effect packages/effect/test/Stream.test.ts -t rechunk(6 passed)nix develop -c pnpm lint-fixnix develop -c pnpm checkgit diff --checkCloses #7654
Closes EFF-1044