fix(RpcSerialization): retain falsy control IDs when decoding JSON-RPC

[kitlangton]

Type

• Bug Fix

Description

JSON-RPC decoding used a truthiness check for control-message request IDs. This dropped valid 0 and "" IDs from Ack and Interrupt messages, breaking request correlation.

The decoder now checks for undefined, preserving both valid falsy values. A focused regression in packages/effect/test/rpc/RpcSerialization.test.ts covers both message tags and both IDs through the public JSON-RPC decoder.

Verification

• pnpm test --run packages/effect/test/rpc/RpcSerialization.test.ts (37 passed)
• pnpm lint-fix
• pnpm check
• git diff --check

Related

Closes #7682
Closes EFF-1058

[changeset-bot]

🦋 Changeset detected

Latest commit: 9209cdd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages

Name	Type
effect	Patch
@effect/opentelemetry	Patch
@effect/vitest	Patch
@effect/ai-anthropic	Patch
@effect/ai-openai-compat	Patch
@effect/ai-openai	Patch
@effect/ai-openrouter	Patch
@effect/atom-react	Patch
@effect/atom-solid	Patch
@effect/atom-vue	Patch
@effect/platform-browser	Patch
@effect/platform-bun	Patch
@effect/platform-deno	Patch
@effect/platform-node-shared	Patch
@effect/platform-node	Patch
@effect/sql-clickhouse	Patch
@effect/sql-d1	Patch
@effect/sql-libsql	Patch
@effect/sql-mssql	Patch
@effect/sql-mysql2	Patch
@effect/sql-pg	Patch
@effect/sql-pglite	Patch
@effect/sql-sqlite-bun	Patch
@effect/sql-sqlite-do	Patch
@effect/sql-sqlite-node	Patch
@effect/sql-sqlite-react-native	Patch
@effect/sql-sqlite-wasm	Patch
@effect/docgen	Patch
@effect/doctest	Patch
@effect/openapi-generator	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

Bundle Size Analysis

Generated from PR build output; treat the content below as untrusted.

File Name	Current Size	Previous Size	Difference
arbitrary-combinators.ts	33.92 KB	33.92 KB	0.00 KB (0.00%)
basic.ts	7.05 KB	7.05 KB	0.00 KB (0.00%)
batching.ts	10.28 KB	10.28 KB	0.00 KB (0.00%)
brand.ts	6.59 KB	6.59 KB	0.00 KB (0.00%)
cache.ts	10.91 KB	10.91 KB	0.00 KB (0.00%)
config.ts	21.62 KB	21.62 KB	0.00 KB (0.00%)
differ.ts	20.43 KB	20.43 KB	0.00 KB (0.00%)
http-client.ts	22.06 KB	22.06 KB	0.00 KB (0.00%)
logger.ts	11.00 KB	11.00 KB	0.00 KB (0.00%)
metric.ts	9.14 KB	9.14 KB	0.00 KB (0.00%)
optic.ts	6.77 KB	6.77 KB	0.00 KB (0.00%)
pubsub.ts	15.38 KB	15.38 KB	0.00 KB (0.00%)
queue.ts	11.98 KB	11.98 KB	0.00 KB (0.00%)
schedule.ts	11.10 KB	11.10 KB	0.00 KB (0.00%)
schema-binary.ts	39.58 KB	39.58 KB	0.00 KB (0.00%)
schema-class.ts	20.18 KB	20.18 KB	0.00 KB (0.00%)
schema-fromJsonSchemaDocument.ts	30.28 KB	30.28 KB	0.00 KB (0.00%)
schema-representation-roundtrip.ts	26.30 KB	26.30 KB	0.00 KB (0.00%)
schema-string-transformation.ts	13.79 KB	13.79 KB	0.00 KB (0.00%)
schema-string.ts	11.28 KB	11.28 KB	0.00 KB (0.00%)
schema-template-literal.ts	15.64 KB	15.64 KB	0.00 KB (0.00%)
schema-toArbitrary.ts	33.48 KB	33.48 KB	0.00 KB (0.00%)
schema-toCodeDocument.ts	24.63 KB	24.63 KB	0.00 KB (0.00%)
schema-toCodecJson.ts	19.39 KB	19.39 KB	0.00 KB (0.00%)
schema-toEquivalence.ts	19.52 KB	19.52 KB	0.00 KB (0.00%)
schema-toFormatter.ts	19.63 KB	19.63 KB	0.00 KB (0.00%)
schema-toJsonSchemaDocument.ts	23.52 KB	23.52 KB	0.00 KB (0.00%)
schema-toRepresentation.ts	19.66 KB	19.66 KB	0.00 KB (0.00%)
schema.ts	19.39 KB	19.39 KB	0.00 KB (0.00%)
stm.ts	12.93 KB	12.93 KB	0.00 KB (0.00%)
stream.ts	9.96 KB	9.96 KB	0.00 KB (0.00%)