fix(RequestResolver): consume tagged iterable results - #7981
Merged
tim-smart merged 4 commits intoSep 4, 2026
Conversation
🦋 Changeset detectedLatest commit: 002a363 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tim-smart
force-pushed
the
audit/c2-r8-resolver-iterable
branch
from
September 4, 2026 02:51
38fbe90 to
85ab609
Compare
tim-smart
marked this pull request as ready for review
September 4, 2026 03:08
tim-smart
force-pushed
the
audit/c2-r8-resolver-iterable
branch
from
September 4, 2026 04:55
278be37 to
ceec1fd
Compare
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
tim-smart
force-pushed
the
audit/c2-r8-resolver-iterable
branch
from
September 4, 2026 05:48
171409f to
002a363
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
RequestResolver.fromEffectTaggedaccepts handlers that return anIterable, but its success path treated results as arrays. Returning an array iterator or generator left requests incomplete.What changes
for...of, matchingfromFunctionBatched.packages/effect/test/Request.test.ts.effectpatch changeset.Scope
Only successful result traversal changes. Result cardinality and failure behavior remain unchanged.
Verification
nix develop -c pnpm test --run packages/effect/test/Request.test.ts nix develop -c pnpm lint-fix nix develop -c pnpm check git diff --checkOn pre-fix
origin/mainat88593e4abc, the array control passed while the iterator and generator regressions failed withRequestResolver did not complete request. After rebasing onto7738b48e48, all 33 tests pass at the PR head.Closes #7980
Closes EFF-1215
Audit
Runtime correctness audit; intended label:
audit.