fix(Metric): canonicalize attribute order in series keys - #7993
Merged
tim-smart merged 5 commits intoSep 4, 2026
Conversation
🦋 Changeset detectedLatest commit: 4f2b1fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
tim-smart
force-pushed
the
audit/c2-r8-metric-attribute-order
branch
from
September 4, 2026 02:51
f4581d3 to
be47bee
Compare
tim-smart
enabled auto-merge (squash)
September 4, 2026 05:37
tim-smart
disabled auto-merge
September 4, 2026 05:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Metrics with the same id and equal attributes could create separate series when the attributes were inserted in a different order.
What changed
Metric.test.ts.Verification
pnpm lint-fix pnpm test --run packages/effect/test/Metric.test.ts packages/opentelemetry/test pnpm --filter effect check git diff --checkCloses #7992
Closes EFF-1221
Audit
Runtime correctness audit; intended label:
audit.