chore: take kbuild 1.2.8 and move CI to JDK 25 - #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
com.eignex.*pins move from 1.2.7 to 1.2.8.Why these are one commit
kbuild 1.2.8 publishes Java 25 bytecode and declares
"org.gradle.jvm.version": 25in its Gradlemodule metadata. Gradle reads that during dependency resolution, so a build whose Gradle runs on
JDK 21 cannot resolve the plugin at all:
Splitting the change fails in either order. Bumping the pin alone breaks on a JDK 21 runner. Moving
CI to JDK 25 alone breaks too, because the 1.2.7 conventions request a toolchain of 21 that a
runner holding only JDK 25 cannot satisfy.
What 1.2.8 brings
Gradle 9.6.1 to 9.7.0, Kotlin 2.3.20 to 2.4.10, Kover 0.9.9, detekt 2.0.0-alpha.5, JUnit 6.1.2,
jvmToolchain(25)across the kmp, jvm and cli conventions, and the plugin jvm target pinned ratherthan inherited from whichever JDK CI happens to run.
Testing
CI only. Once this lands the build needs JDK 25, which the machine used to prepare it does not have
and cannot auto-provision, so nothing here was built locally.
Local development needs a JDK 25 installed after this merges; no repo configures a toolchain
resolver.