Skip to content

Replace Playwright test with extended Cypress tests#333

Merged
ElMassimo merged 1 commit into
vite-8from
claude/fix-playwright-test-9Iwkl
Mar 25, 2026
Merged

Replace Playwright test with extended Cypress tests#333
ElMassimo merged 1 commit into
vite-8from
claude/fix-playwright-test-9Iwkl

Conversation

@ElMassimo

Copy link
Copy Markdown
Owner

Summary

  • Removed the Playwright-based docs/tests/docs.spec.ts that was failing in CI (along with playwright and @playwright/test dependencies)
  • Extended the existing Cypress docsearch test to cover search query + result navigation and search-after-turbo-navigation
  • Added a PWA manifest validation test (pwa-manifest.json) to the Cypress home page tests
  • Removed the Playwright install step from the CI workflow

Test plan

  • CI tests job passes without Playwright
  • Cypress docsearch tests pass: open/close modal, search for "hydration", click result, verify navigation
  • Cypress home tests pass: PWA manifest returns valid JSON with correct fields

https://claude.ai/code/session_018FtfWUndE6xV56cJUwZHLs

Remove the Playwright-based docs.spec.ts test that was failing in CI and
move its test coverage into the existing Cypress test suite:

- Extended docsearch Cypress test with search query + result navigation
- Extended docsearch Cypress test with search-after-turbo-navigation scenario
- Added PWA manifest validation test to home page Cypress tests
- Removed Playwright dependencies from package.json
- Removed Playwright install step from CI workflow

https://claude.ai/code/session_018FtfWUndE6xV56cJUwZHLs
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying iles with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7a0b7de
Status:🚫  Build failed.

View logs

@nx-cloud

nx-cloud Bot commented Mar 25, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 7a0b7de

Command Status Duration Result
nx run-many --target=build --all --exclude docs... ✅ Succeeded 37s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-25 16:11:50 UTC

@ElMassimo
ElMassimo changed the base branch from main to vite-8 March 25, 2026 16:30
@ElMassimo
ElMassimo merged commit 4538824 into vite-8 Mar 25, 2026
8 of 11 checks passed
@ElMassimo
ElMassimo deleted the claude/fix-playwright-test-9Iwkl branch March 25, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants