Replace Playwright test with extended Cypress tests#333
Merged
Conversation
Remove the Playwright-based docs.spec.ts test that was failing in CI and move its test coverage into the existing Cypress test suite: - Extended docsearch Cypress test with search query + result navigation - Extended docsearch Cypress test with search-after-turbo-navigation scenario - Added PWA manifest validation test to home page Cypress tests - Removed Playwright dependencies from package.json - Removed Playwright install step from CI workflow https://claude.ai/code/session_018FtfWUndE6xV56cJUwZHLs
|
View your CI Pipeline Execution ↗ for commit 7a0b7de
☁️ Nx Cloud last updated this comment at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/tests/docs.spec.tsthat was failing in CI (along withplaywrightand@playwright/testdependencies)docsearchtest to cover search query + result navigation and search-after-turbo-navigationpwa-manifest.json) to the Cypress home page testsTest plan
testsjob passes without Playwrightdocsearchtests pass: open/close modal, search for "hydration", click result, verify navigationhometests pass: PWA manifest returns valid JSON with correct fieldshttps://claude.ai/code/session_018FtfWUndE6xV56cJUwZHLs