Skip to content

✨ Validate Election Manifest #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
keithrfung merged 2 commits into from
Nov 7, 2020
Merged

✨ Validate Election Manifest #126

keithrfung merged 2 commits into from
Nov 7, 2020

Conversation

@keithrfung
Copy link
Contributor

@keithrfung keithrfung commented Nov 5, 2020 •
edited
Loading

Issue

Fixes #127

Description

Screen Shot 2020-11-06 at 7 33 35 PM

- Add `election/validate/description` to validate election manifests and descriptions - Add postman tests

Testing

  • Postman Tests election/validate/description

Checklist

🚨Please review the guidelines for contributing to this repository.

  • 🤔 CONSIDER adding a unit test if your PR resolves an issue.
  • ✅ DO check open PR's to avoid duplicates.
  • ✅ DO keep pull requests small so they can be easily reviewed.
  • ✅ DO build locally before pushing.
  • ✅ DO make sure tests pass.
  • ✅ DO make sure any new changes are documented.
  • ✅ DO make sure not to introduce any compiler warnings.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

💔Thank you!

@keithrfung keithrfung requested a review from rkorsak November 5, 2020 18:43
@keithrfung keithrfung added blocked Blocked from progress and removed blocked Blocked from progress labels Nov 5, 2020
@keithrfung keithrfung force-pushed the feature/validate-manifest branch 2 times, most recently from 82630e9 to 80df4ec Compare November 6, 2020 19:44
@keithrfung
✨ Validate Election Manifest
5a49435 
- Add `election/validate/description` to validate election manifests and descriptions
- Add postman tests
- ♻️ Update to use lru cache
@keithrfung keithrfung force-pushed the feature/validate-manifest branch from 80df4ec to 5a49435 Compare November 6, 2020 20:41
@keithrfung keithrfung merged commit 23a5f57 into main Nov 7, 2020
@keithrfung keithrfung deleted the feature/validate-manifest branch November 7, 2020 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rkorsak rkorsak rkorsak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Validate Election Manifest and Descriptions

3 participants

@keithrfung @rkorsak