Skip to content

Conversation

@AddressXception
Copy link
Contributor

Checklist

🚨Please review the guidelines for contributing to this repository.

  • 🤔 CONSIDER adding a unit test if your PR resolves an issue.
  • DO check open PR's to avoid duplicates.
  • DO keep pull requests small so they can be easily reviewed.
  • DO build locally before pushing.
  • DO make sure tests pass.
  • DO make sure any new changes are documented.
  • DO make sure not to introduce any compiler warnings.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

Description

Fixes: #33

also searches for data directory in calling context on startup

only tested on linux

To Test

  1. load the postman collection changes
  2. execute Implement Decrypt API Call #1 GET to verify api exists
  3. Expected: log messages include DATA: resolved at: /your/path/to/microsoft/ElectionGuard-SDK-DotNetCore-Reference-Web-API/data

💔Thank you!

@AddressXception AddressXception added the enhancement New feature or request label Jan 29, 2020
@AddressXception AddressXception added this to the Phase 3 milestone Jan 29, 2020
@AddressXception AddressXception merged commit 307fc22 into feature/encrypter-integration-isolated Jan 29, 2020
keithrfung added a commit that referenced this pull request Jan 31, 2020
* ✨ Encrypt Ballot Endpoint

Encrypt a single ballot via endpoint. 
Provide new ways to pass in the ElectionMap and ElectionGuardConnfig to remove the restrictions from coming into the pathway from different directions. This also allows for a different direction for the current count which now can be passed in OR just simply incremented.

* Rework the mock EncryptBallot API

add support for loading configuration at runtime from a relative path

* Feature/modify controller endpoint (#34)

* Change route from /election to /electionguard

* check the call context for data directory

if failed check the parent folder

Co-authored-by: Matt Wilhelm <AddressXception@users.noreply.github.com>
keithrfung added a commit that referenced this pull request Feb 1, 2020
* ✨ Encrypt Ballot Endpoint

Encrypt a single ballot via endpoint. 
Provide new ways to pass in the ElectionMap and ElectionGuardConnfig to remove the restrictions from coming into the pathway from different directions. This also allows for a different direction for the current count which now can be passed in OR just simply incremented.

* Rework the mock EncryptBallot API

add support for loading configuration at runtime from a relative path

* Feature/modify controller endpoint (#34)

* Change route from /election to /electionguard

* check the call context for data directory

if failed check the parent folder

* Implement Encrypt Ballot

Rework API's for data consistency.  Update postman collection for new requests

* Fix typo. disable request size limits

* try catch on all methods.  Validate RecordBallots input data

when RecordBallots is called, de-dupe the ballots, taking the first & verify the cast/spoiled count matches the de-duplicated dataset count.

* update tallies

* add example curl commands

* use last encrypted ballot

PR feedback

Co-authored-by: Keith Fung <keithrfung@users.noreply.github.com>
@keithrfung keithrfung deleted the feature/modify-controller-endpoint branch February 5, 2020 14:41
keithrfung added a commit that referenced this pull request Feb 13, 2020
* ✨ Encrypt Ballot Endpoint

Encrypt a single ballot via endpoint. 
Provide new ways to pass in the ElectionMap and ElectionGuardConnfig to remove the restrictions from coming into the pathway from different directions. This also allows for a different direction for the current count which now can be passed in OR just simply incremented.

* Rework the mock EncryptBallot API

add support for loading configuration at runtime from a relative path

* Feature/modify controller endpoint (#34)

* Change route from /election to /electionguard

* check the call context for data directory

if failed check the parent folder

Co-authored-by: Matt Wilhelm <AddressXception@users.noreply.github.com>
keithrfung added a commit that referenced this pull request Feb 13, 2020
* ✨ Encrypt Ballot Endpoint

Encrypt a single ballot via endpoint. 
Provide new ways to pass in the ElectionMap and ElectionGuardConnfig to remove the restrictions from coming into the pathway from different directions. This also allows for a different direction for the current count which now can be passed in OR just simply incremented.

* Rework the mock EncryptBallot API

add support for loading configuration at runtime from a relative path

* Feature/modify controller endpoint (#34)

* Change route from /election to /electionguard

* check the call context for data directory

if failed check the parent folder

* Implement Encrypt Ballot

Rework API's for data consistency.  Update postman collection for new requests

* Fix typo. disable request size limits

* try catch on all methods.  Validate RecordBallots input data

when RecordBallots is called, de-dupe the ballots, taking the first & verify the cast/spoiled count matches the de-duplicated dataset count.

* update tallies

* add example curl commands

* use last encrypted ballot

PR feedback

Co-authored-by: Keith Fung <keithrfung@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants