Fix Build warning C4068 for MSVC#221
Merged
AddressXception merged 1 commit intoElection-Tech-Initiative:mainfrom Oct 22, 2021
Merged
Fix Build warning C4068 for MSVC#221AddressXception merged 1 commit intoElection-Tech-Initiative:mainfrom
AddressXception merged 1 commit intoElection-Tech-Initiative:mainfrom
Conversation
Contributor
|
@avinal One of the builds failed. Take a look. |
avinal
force-pushed
the
avinal/issue216
branch
from
4111a84 to
fe42ed8
Compare
- GCC pragma is not a valid pragma in MSVC, thus produces warning C4068: unknown pragma 'GCC'. - The workaround is to encapsulate the GCC pragma in if GNUC defined block. Signed-off-by: Avinal Kumar <avinal.xlvii@gmail.com>
avinal
force-pushed
the
avinal/issue216
branch
from
fe42ed8 to
f873122
Compare
Contributor
Author
|
Hey @keithrfung, mistakenly I wrapped the whole pragma into if directive, I have fixed it now. |
Contributor
Author
|
Finally 😅 its complete |
Contributor
|
@avinal I know right? It's a long build. hahaha. |
keithrfung
reviewed
Oct 21, 2021
Contributor
keithrfung
left a comment
keithrfung
left a comment
There was a problem hiding this comment.
This looks good to me. I'm going to let @AddressXception review this though.
Marking this as hacktoberfest-approved.
keithrfung
added
the
hacktoberfest-accepted
Contributor
Author
Very long🥲, and for 4 line change it felt like a lifetime 😂. |
AddressXception
approved these changes
Oct 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Avinal Kumar avinal.xlvii@gmail.com
Issue
Link your PR to an issue
Fixes #216
Description
unknown pragma 'GCC'.
block.
Testing
Describe the best way to test or validate your PR.