✅ Balerion HotFix for Release Build Workflow #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithrfung
force-pushed
the
feature/pull-request-ci
branch
from
3993489 to
e1608b5
Compare
keithrfung
changed the title
keithrfung
force-pushed
the
feature/pull-request-ci
branch
2 times, most recently
from
c3bb1de to
3341b7c
Compare
- Reduce MacOS and Windows to only run integration tests. - Add make file to run all integration tests
- Simplify commands for CI - Add test pypi commands for CI for easy flipping - Add noshow to stop existing issue - Add release commands
keithrfung
force-pushed
the
feature/pull-request-ci
branch
from
38ec827 to
1fc1906
Compare
keithrfung
commented
Aug 5, 2020
| verify_ssl = true | ||
|
|
||
| [dev-packages] | ||
| atomicwrites = "*" |
Contributor
Author
There was a problem hiding this comment.
This is required for windows tests. pytest requires it but it is not installed by default.
keithrfung
commented
Aug 5, 2020
| dependency-graph-ci: | ||
| sudo apt install graphviz | ||
| pip install pydeps | ||
| pydeps --noshow --max-bacon 2 -o dependency-graph.svg src/electionguard |
Contributor
Author
There was a problem hiding this comment.
The lack of this --no-show is what caused the build to fail.
keithrfung
commented
Aug 5, 2020
| release_name: Release ${{ env.PACKAGE_VERSION }} | ||
| draft: false | ||
| prerelease: false | ||
| - name: Dependency Graph |
Contributor
Author
There was a problem hiding this comment.
Moved the order of this up so it wouldn't block the rest of the build after pypi is pushed.
Contributor
Author
|
Please review. |
rc-ms
approved these changes
Aug 7, 2020
Contributor
|
This looks great! Thank you for your patience Keith! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #121
Fixes #141
Fixes #142
Description
Testing
https://github.com/microsoft/electionguard-python/runs/951389340?check_suite_focus=true
Checklist
🚨Please review the guidelines for contributing to this repository.
💚Thank you!