Skip to content

Conversation

@TuTomasz
Copy link
Contributor

@TuTomasz TuTomasz commented Sep 25, 2020

Issue

Fixes #170

Description

Implements method auto-lint in the MakeFile to perform code reformat using black prior to linting.
Auto-lint wraps the lint method. Introduced it in "make all" as part of the build process.

Testing

Code review.

Checklist

🚨Please review the guidelines for contributing to this repository.

  • 🤔 CONSIDER adding a unit test if your PR resolves an issue.
  • DO check open PR's to avoid duplicates.
  • DO keep pull requests small so they can be easily reviewed.
  • DO build locally before pushing.
  • DO make sure tests pass.
  • DO make sure any new changes are documented.
  • DO make sure not to introduce any compiler warnings.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

💚Thank you!

@keithrfung
Copy link
Contributor

Thanks for your pull request! We'll be reviewing shortly.

Copy link
Contributor

@rkorsak rkorsak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed this works exactly as expected locally, and I've wanted exactly this feature all day today 😆.

Thanks for the contribution!

I have one small open question to other folks, but otherwise this looks good to me.

SAMPLE_BALLOT_SPOIL_RATE ?= 50

all: environment install validate lint coverage
all: environment install validate auto-lint coverage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keithrfung / @AddressXception - any objection to running the auto-lint here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. That's good for my perspective. Makes sense.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im in favor too

@TuTomasz
Copy link
Contributor Author

Awesome no problem glad to be of help 😃.

@keithrfung keithrfung added the hacktoberfest-accepted Pull Request will count towards Hacktoberfest label Oct 5, 2020
@keithrfung keithrfung merged commit 5cab8c9 into Election-Tech-Initiative:main Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Pull Request will count towards Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create method to auto-lint with black

4 participants