-
Notifications
You must be signed in to change notification settings - Fork 103
Created method to reformat with black prior to linting. #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created method to reformat with black prior to linting. #185
Conversation
|
Thanks for your pull request! We'll be reviewing shortly. |
rkorsak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've confirmed this works exactly as expected locally, and I've wanted exactly this feature all day today 😆.
Thanks for the contribution!
I have one small open question to other folks, but otherwise this looks good to me.
| SAMPLE_BALLOT_SPOIL_RATE ?= 50 | ||
|
|
||
| all: environment install validate lint coverage | ||
| all: environment install validate auto-lint coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@keithrfung / @AddressXception - any objection to running the auto-lint here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. That's good for my perspective. Makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im in favor too
|
Awesome no problem glad to be of help 😃. |
Issue
Fixes #170
Description
Implements method auto-lint in the MakeFile to perform code reformat using black prior to linting.
Auto-lint wraps the lint method. Introduced it in "make all" as part of the build process.
Testing
Code review.
Checklist
🚨Please review the guidelines for contributing to this repository.
💚Thank you!