Conversation
51ca306 to
09b2857
Compare
keithrfung
previously approved these changes
Sep 28, 2020
Contributor
keithrfung
left a comment
There was a problem hiding this comment.
looks good to me.
Wouldn't mind second review here @AddressXception
| """ | ||
| Return the number of ticks for a date time | ||
| Return the number of ticks for a date time. | ||
| Ticks are defined here as number of seconds since the unix epoch (00:00:00 UTC on 1 January 1970) |
Contributor
There was a problem hiding this comment.
Appreciate the verbage here.
rkorsak
commented
Sep 28, 2020
keithrfung
approved these changes
Sep 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #190
Description
utils.to_ticksfunction to use the unix epoch (seconds since January 1, 1970 UTC)datetime.utcnowwithdatetime.now, asutcnowis considered harmful and ironically produces the wrong epoch timestamp.Note: sample data will need to be regenerated, but we have several other hashing/format changes coming and should address that in one sweep.
Testing
Unit tests for
utils.to_tickshave been augmented to cover more flavors of datetime.Checklist
🚨Please review the guidelines for contributing to this repository.
💚 Thank you!