Skip to content

Cleanup tracker words #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
keithrfung merged 9 commits into from
Oct 29, 2020
Merged

Cleanup tracker words #231

keithrfung merged 9 commits into from
Oct 29, 2020

Conversation

@keithrfung
Copy link
Contributor

@keithrfung keithrfung commented Oct 29, 2020

Issue

Fixes #230

Description

  • Remove words from tracker list

Testing

  • Visibly review the tracker word list

Checklist

🚨Please review the guidelines for contributing to this repository.

  • 🤔 CONSIDER adding a unit test if your PR resolves an issue.
  • ✅ DO check open PR's to avoid duplicates.
  • ✅ DO keep pull requests small so they can be easily reviewed.
  • ✅ DO build locally before pushing.
  • ✅ DO make sure tests pass.
  • ✅ DO make sure any new changes are documented.
  • ✅ DO make sure not to introduce any compiler warnings.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

💚Thank you!

@keithrfung keithrfung changed the title Fix/cleanup tracker words Cleanup tracker words Oct 29, 2020
@keithrfung keithrfung added the hacktoberfest-accepted Pull Request will count towards Hacktoberfest label Oct 29, 2020
@keithrfung keithrfung force-pushed the fix/cleanup-tracker-words branch from d542a20 to 5ed8073 Compare October 29, 2020 19:41
AddressXception
AddressXception approved these changes Oct 29, 2020
View reviewed changes
src/electionguard/words.py Outdated
"affiliate",
"affinity",
"afoul",
"afterlife",
Copy link
Contributor

@AddressXception AddressXception Oct 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👎 afterlife

@keithrfung keithrfung merged commit c32ec6a into main Oct 29, 2020
@keithrfung keithrfung deleted the fix/cleanup-tracker-words branch October 29, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@AddressXception AddressXception AddressXception approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

hacktoberfest-accepted Pull Request will count towards Hacktoberfest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🧹 Cleanup Tracker Word List

5 participants

@keithrfung @AddressXception @rc-ms @john-s-morgan