Handle dates consistently#366
Merged
AddressXception merged 4 commits intomainfrom May 24, 2021
Merged
Conversation
add hash tests
SteveMaier-IRT
previously approved these changes
May 13, 2021
keithrfung
approved these changes
May 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add hash tests
🚨 Please review the guidelines for contributing to this repository.
Issue
Link your PR to an issue
Fixes #365
Description
This PR fixes some serialization issues between the c++ and python code. Specifically fixing the serialization of dates, ensuring all numbers get hashed as hex strings, and adding some audit logs.
Testing
make test