Bug/#1084 - Visual studio loading issue - #1087
Conversation
epsnm
commented
Jul 27, 2026
- Fix visual studio loading issue
- Let electron-builder choose current platform when not in WSL cross-compile mode
- MSBuild configuration barriers to be included in projects with CPM
FlorianRappl
left a comment
There was a problem hiding this comment.
In general looks great, but please keep existing JS.Sdk and I am not sure I understand the reason for pulling so many files into the root directory. From my perspective these changes are unrelated to the runtime identifier issue, but maybe I am not seeing the full picture here.
- Moved Directory.Build.* barriers from nuke to root folder to cover all projects. - Added a Directory.Packages.props barrier to stop central package management. - Removed obsolete 'ManagePackageVersionsCentrally' properties.
|
After reading the tests results it seems only one macos test is in error (macos-15-intel API-30.4.0) I've didn't catch how it can be related to these changes. Did you have other tests-runs that sometime fail for no apparent reason ? I'll investigate with a run-until-fail session on a similar macos version. |
|
No need for this. Macos tests / machines are unfortunately flaky. Quite often just re-running the test on that particular image will succeed. It's a different story if multiple/all are failing. |
pr-comment: Run #113
🎉 All tests passed!Github Test Reporter by CTRF 💚 |