Add quicktext button#240
Closed
mrjacobbloom wants to merge 2 commits intoElementalCode:gh-pagesfrom
mrjacobbloom:quick-text-button
Closed
Add quicktext button#240mrjacobbloom wants to merge 2 commits intoElementalCode:gh-pagesfrom mrjacobbloom:quick-text-button
mrjacobbloom wants to merge 2 commits intoElementalCode:gh-pagesfrom
mrjacobbloom:quick-text-button
Conversation
| } | ||
| }); | ||
|
|
||
| SCRIPTING_AREA.addEventListener('click', function(ev) { |
Contributor
Author
There was a problem hiding this comment.
This is what's causing the merge conflict. #236 also added stuff to this line
Contributor
Author
There was a problem hiding this comment.
(I needed to figure out how to pull from upstream, I think I got that figured out)
Contributor
There was a problem hiding this comment.
git pull origin branch-name
Contributor
Author
There was a problem hiding this comment.
but I have my own fork so I added this repo as a separate remote
Contributor
There was a problem hiding this comment.
Just use branches from now on maybe
Conflicts: resources/js/blocks.js -- resolved
Contributor
Author
|
Aaaaach this is a mess, I'm gonna redo these changes from a fresh branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #205
Add a button to easily add text to empty c-blocks