Quicktext Button - round 2#241
Merged
matthewr6 merged 3 commits intoElementalCode:gh-pagesfrom Jan 5, 2017
mrjacobbloom:quicktext2
Merged
Quicktext Button - round 2#241matthewr6 merged 3 commits intoElementalCode:gh-pagesfrom mrjacobbloom:quicktext2
matthewr6 merged 3 commits intoElementalCode:gh-pagesfrom
mrjacobbloom:quicktext2
Conversation
Contributor
Author
|
Are there any changes you wanna see before we merge this in? I know it fails CI but I can't figure out what failed the tests |
Contributor
|
It's because it's on gh-pages which doesn't have tests and I haven't set it up to not run tests on this branch. I just haven't worked on Elemental for a long time |
Contributor
Author
|
lol ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add quicktext button as discussed in #205
This is a do-over of botched PR #240. I made a few changes from that code: I consolidated some CSS and made sure the site (stage?) updates when the text element appears