docs: add block header serialization doc and examples#1217
Merged
psgreco merged 2 commits intoElementsProject:masterfrom Sep 14, 2023
Merged
docs: add block header serialization doc and examples#1217psgreco merged 2 commits intoElementsProject:masterfrom
psgreco merged 2 commits intoElementsProject:masterfrom
Conversation
delta1
force-pushed
the
block-header-format
branch
from
dd606ce to
a272c3d
Compare
philippem
reviewed
Apr 3, 2023
| | Proposed | Yes | | `DynaFedParamEntry` | The proposed DynaFed parameters for the next [epoch](https://github.com/ElementsProject/elements/blob/elements-22.1/src/chainparamsbase.cpp#L60) | | ||
|
|
||
| #### DynaFed Parameters Entry (`class DynaFedParamEntry`) | ||
|
|
Contributor
There was a problem hiding this comment.
it would be helpful to add an explanation of when the different entry types appear (e.g. beginning of epochs, proposing and non-proposing epochs)
Member
Author
There was a problem hiding this comment.
Added some explanation in new commit: 1af35c2#diff-56e0e05da38ca56b8f9ab1b276cec7acb38f26eeaf3215fa88799e639a67227aR86
philippem
reviewed
Apr 3, 2023
philippem
reviewed
Apr 3, 2023
philippem
reviewed
Apr 3, 2023
|
|
||
| 32 bytes - **previous block hash** | ||
|
|
||
| `f66be8726f4afecc9a7b087a78cd25edd53485755d26e456d546bcc0613a30f9` |
Contributor
There was a problem hiding this comment.
is it worth pointing out that this the hash here is in little-endian (reversed) order?
Member
Author
There was a problem hiding this comment.
Contributor
|
ack |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a doc that describes the serialization of block header fields, and a few examples of deserializing block headers from hex
rendered