Skip to content

change type of vin to numeric in issueasset response.#193

Merged
instagibbs merged 1 commit intoElementsProject:elements-0.14.1from
AkioNak:issueaseet-response
Jun 24, 2017
Merged

change type of vin to numeric in issueasset response.#193
instagibbs merged 1 commit intoElementsProject:elements-0.14.1from
AkioNak:issueaseet-response

Conversation

@AkioNak
Copy link
Copy Markdown
Contributor

@AkioNak AkioNak commented Jun 23, 2017

vin may always represents as numeric in rcp wallet(asset) command response.
but current implementation is following.

rpc command response help text
issueasset string (not descripted)
reissueasset numeric (not descripted)
listissuances numeric numeric

@instagibbs
Copy link
Copy Markdown
Contributor

utACK

@jtimon jtimon added the 0.14.1 label Jun 23, 2017
@jtimon
Copy link
Copy Markdown
Contributor

jtimon commented Jun 23, 2017

Perhaps s/input number/input position/ ?
Perhaps also s/vin/nIn/ or s/vin/in_pos/ or something?

utACK

@instagibbs
Copy link
Copy Markdown
Contributor

I think vin follows the established standard ie vout in createraw etc.

@instagibbs
Copy link
Copy Markdown
Contributor

please squash and I'll merge

@AkioNak AkioNak force-pushed the issueaseet-response branch from 5e719e7 to 994e79c Compare June 23, 2017 23:59
@AkioNak
Copy link
Copy Markdown
Contributor Author

AkioNak commented Jun 24, 2017

@instagibbs done.

@instagibbs instagibbs merged commit 73c9050 into ElementsProject:elements-0.14.1 Jun 24, 2017
@AkioNak AkioNak deleted the issueaseet-response branch June 26, 2017 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants