Set policyAsset for core unit tests #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
utACK 2bf55e1 |
instagibbs
reviewed
Sep 16, 2018
| spends[i].vin[0].prevout.n = 0; | ||
| spends[i].vout.resize(2); | ||
| spends[i].vout[0].nValue = 11*CENT; | ||
| spends[i].vout[0].nValue = MAX_MONEY-11*CENT; |
instagibbs
added a commit
that referenced
this pull request
Sep 16, 2018
2bf55e1 Set policy asset for core unit tests (nkostoulas)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set policyAsset for all core c++ unit tests #408
src/test/txvalidationcache_tests.cpp was failing with memory access violation somewhere in block creation. I believe it's because now that mempool entry fee is correctly set, the fact that the fee output was larger than the non-fee one was causing an issue. I haven't been able to track this down exactly though. Please let me know if you have some idea about this and if the change makes sense.