-
Notifications
You must be signed in to change notification settings - Fork 397
Updated README links to point to new elementsproject.org content. #440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated README links to point to new elementsproject.org content. #440
Conversation
|
SW I understand, but why was Schnorr also omitted from the new website? Just curious. |
|
@stevenroose - It was listed on this page as being current but that was not the case: https://github.com/ElementsProject/elementsproject.org/blob/master/source/elements/index.md so I just removed it. Perhaps too hasty of me. So...using this as the as the source: https://github.com/ElementsProject/elementsproject.org/blob/master/source/elements/schnorr-signatures/index.md I will raise a PR on the new site and add a link to it here for review. If that's fine I'll change this PR (440) to include a link to it. That sound ok? Cheers, Matt. |
|
@stevenroose the PR to create the content is here for review: ElementsProject/elementsproject.github.io#19 If that is ok I will merge that and amend this PR (440) to point to it as a 'Research phase' feature. |
|
Afaik we had schnorr for elements alpha but we don't have it for elements-0.14.1 anymore. Perhaps we can still point to the alpha code for that. |
|
Oh, oops. Considered we still had an opcode for it. My bad. |
|
so @jtimon , @stevenroose - are you happy that I add the page to elementsproject.org as per the PR here: ElementsProject/elementsproject.github.io#19 Basically - mentions Schnorr as 'research phase' and gives details as per the investigation done by Patrick Strateman. @jtimon - I can add a link to the alpha code if you like? What would I link to and what is Alpha for now? I thought it was defunct? |
|
Yeah alpha is no more afaik. It also seems that Schnorr efforts moved to Core and we'll just take it over once it lands there. But it might be worth mentioning that we used to have it. |
|
We'll likely take on Schnorr immediately once it's merged into libsecp, in whatever form. |
|
Ok then - so I will merge the PR on .org then to point to the investigation page and say it is not currently in Elements and commit a change to add the link to this PR here. Then again, there seems little point in saying we will use new Bitcoin features as that's a bit open in terms of what we can list. Maybe we should just leave it off now, the site already mentions we build on Bitcoin and extend it. Hmmm. Thoughts? |
|
I've put the link to Schnorr back - it points to the Schnorr research page on .org which was all there was on the old site about it For ref that is http://elementsproject.org/features/schnorr-signatures This PR ok from your pov now @instagibbs @stevenroose ? |
|
LGTM.. I'd await @instagibbs 's opinion :) |
|
utACK, links look right |
…content. 61cbc79 changed link name for easier diff (wintercooled) ef0451d added link to schnorr as research (wintercooled) 2652861 Modified intro text (wintercooled) f68ba12 Modified what is elements? text (wintercooled) b0ac198 changed link from github.io to .org (wintercooled) 7b2a331 Amend links to point at new .org site content (wintercooled)
Changed links to point to new website content and removed references to old pages.
Includes some minor text changes to the intro and summary to remove suggestion its intended primary use is as a Bitcoin testbed.
Removed links to Schnorr, SW as these do not have pages on the new site (can add if needed).