Skip to content

Conversation

@wintercooled
Copy link
Contributor

Changed links to point to new website content and removed references to old pages.

Includes some minor text changes to the intro and summary to remove suggestion its intended primary use is as a Bitcoin testbed.

Removed links to Schnorr, SW as these do not have pages on the new site (can add if needed).

@wintercooled wintercooled changed the title Updated links to point to new elementsproject.org content. Updated README links to point to new elementsproject.org content. Oct 20, 2018
@stevenroose
Copy link
Contributor

SW I understand, but why was Schnorr also omitted from the new website? Just curious.

@wintercooled
Copy link
Contributor Author

@stevenroose - It was listed on this page as being current but that was not the case: https://github.com/ElementsProject/elementsproject.org/blob/master/source/elements/index.md so I just removed it. Perhaps too hasty of me. So...using this as the as the source: https://github.com/ElementsProject/elementsproject.org/blob/master/source/elements/schnorr-signatures/index.md

I will raise a PR on the new site and add a link to it here for review.

If that's fine I'll change this PR (440) to include a link to it. That sound ok?

Cheers, Matt.

@wintercooled
Copy link
Contributor Author

@stevenroose the PR to create the content is here for review:

ElementsProject/elementsproject.github.io#19

If that is ok I will merge that and amend this PR (440) to point to it as a 'Research phase' feature.

@jtimon jtimon added the 0.14.1 label Oct 22, 2018
@jtimon
Copy link
Contributor

jtimon commented Oct 22, 2018

Afaik we had schnorr for elements alpha but we don't have it for elements-0.14.1 anymore. Perhaps we can still point to the alpha code for that.

@stevenroose
Copy link
Contributor

Oh, oops. Considered we still had an opcode for it. My bad.

@wintercooled
Copy link
Contributor Author

so @jtimon , @stevenroose - are you happy that I add the page to elementsproject.org as per the PR here: ElementsProject/elementsproject.github.io#19

Basically - mentions Schnorr as 'research phase' and gives details as per the investigation done by Patrick Strateman.

@jtimon - I can add a link to the alpha code if you like? What would I link to and what is Alpha for now? I thought it was defunct?

@stevenroose
Copy link
Contributor

Yeah alpha is no more afaik. It also seems that Schnorr efforts moved to Core and we'll just take it over once it lands there. But it might be worth mentioning that we used to have it.

@instagibbs
Copy link
Contributor

We'll likely take on Schnorr immediately once it's merged into libsecp, in whatever form.

@wintercooled
Copy link
Contributor Author

Ok then - so I will merge the PR on .org then to point to the investigation page and say it is not currently in Elements and commit a change to add the link to this PR here. Then again, there seems little point in saying we will use new Bitcoin features as that's a bit open in terms of what we can list. Maybe we should just leave it off now, the site already mentions we build on Bitcoin and extend it. Hmmm. Thoughts?

@wintercooled
Copy link
Contributor Author

I've put the link to Schnorr back - it points to the Schnorr research page on .org which was all there was on the old site about it

For ref that is http://elementsproject.org/features/schnorr-signatures

This PR ok from your pov now @instagibbs @stevenroose ?

@stevenroose
Copy link
Contributor

LGTM.. I'd await @instagibbs 's opinion :)

@instagibbs
Copy link
Contributor

utACK, links look right

@instagibbs instagibbs merged commit 61cbc79 into ElementsProject:elements-0.14.1 Oct 31, 2018
instagibbs added a commit that referenced this pull request Oct 31, 2018
…content.

61cbc79 changed link name for easier diff (wintercooled)
ef0451d added link to schnorr as research (wintercooled)
2652861 Modified intro text (wintercooled)
f68ba12 Modified what is elements? text (wintercooled)
b0ac198 changed link from github.io to .org (wintercooled)
7b2a331 Amend links to point at new .org site content (wintercooled)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants