Changed tutorial bitcoin config file to work with new core v0.17 format#454
Merged
instagibbs merged 2 commits intoElementsProject:elements-0.14.1from Nov 2, 2018
wintercooled:elements-0.14.1
Merged
Changed tutorial bitcoin config file to work with new core v0.17 format#454instagibbs merged 2 commits intoElementsProject:elements-0.14.1from wintercooled:elements-0.14.1
instagibbs merged 2 commits intoElementsProject:elements-0.14.1from
wintercooled:elements-0.14.1
Conversation
This was referenced Nov 1, 2018
AkioNak
reviewed
Nov 2, 2018
| txindex=1 | ||
|
|
||
| regtest.rpcuser=user3 | ||
| regtest.rpcpassword=password3 |
Contributor
There was a problem hiding this comment.
I think these 2 lines are redundant because rpcuser and rpcpassword will apply to all networks if they are not in any section.
Contributor
Author
There was a problem hiding this comment.
I see - I will retest and amend accordingly. Thanks.
Contributor
Author
There was a problem hiding this comment.
I have updated the PR and removed .rpcuser and .rpcpassword and tested on 0.17 and 0.16.2 thanks @AkioNak
Contributor
|
thanks for the review @AkioNak |
instagibbs
added a commit
that referenced
this pull request
Nov 2, 2018
…e v0.17 format 16113d8 Removed redundant .rpcuser, .rpcpassword (wintercooled) 370e797 Changed config file to work with new core v0.17 format as well as previous versions (wintercooled) Pull request description: Core v0.17 now handles config file settings differently and loads the existing config settings as mainnet and not regtest. This means our e1 and e2 nodes in the tutorial can't connect. This PR makes the bitcoin.conf file compatible with both formats. Without this change the tutorial code fails if you are using bitcoind v0.17.0.0. REF: https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-0.17.0.md If the following options are not in a section, they will only apply to mainnet: `addnode=`, `connect=`, `port=`, `bind=`, `rpcport=`, `rpcbind=` and `wallet=`. The options to choose a network (`regtest=` and `testnet=`) must be specified outside of sections. Tested with bitcoind v0.16.2.0 and v0.17.0.0 Tree-SHA512: 3136703da17570e410c1e86ab31f3ac0bca60847164dd10e75a57affd1b7b67fdfbba2be5437ad9ffdd5428c10f6d34073d3e746f55dacda858ab47b517cd3fc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core v0.17 now handles config file settings differently and loads the existing config settings as mainnet and not regtest. This means our e1 and e2 nodes in the tutorial can't connect.
This PR makes the bitcoin.conf file compatible with both formats. Without this change the tutorial code fails if you are using bitcoind v0.17.0.0.
REF: https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-0.17.0.md
If the following options are not in a section, they will only apply to mainnet:
addnode=,connect=,port=,bind=,rpcport=,rpcbind=andwallet=.The options to choose a network (
regtest=andtestnet=) must be specifiedoutside of sections.
Tested with bitcoind v0.16.2.0 and v0.17.0.0