Skip to content

Wally 1.4.0 update #8158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 20, 2025
Merged

Wally 1.4.0 update #8158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52e29b3
wally: update libwally to 1.4.0
jgriffiths Mar 12, 2025
9247ec9
psbt: avoid duplicating the input string when parsing from base64
jgriffiths Mar 12, 2025
beffd02
hsmd: enable caching of sub-hashes when signing our PSBT inputs
jgriffiths Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions bitcoin/psbt.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -761,10 +761,9 @@ struct wally_psbt *psbt_from_b64(const tal_t *ctx,
size_t b64len)
{
struct wally_psbt *psbt;
char *str = tal_strndup(tmpctx, b64, b64len);

tal_wally_start();
if (wally_psbt_from_base64(str, /* flags */ 0, &psbt) == WALLY_OK)
if (wally_psbt_from_base64_n(b64, b64len, /* flags */ 0, &psbt) == WALLY_OK)
tal_add_destructor(psbt, psbt_destroy);
else
psbt = NULL;
Expand Down
2 changes: 1 addition & 1 deletion external/libwally-core
Open in desktop
Submodule libwally-core updated 101 files
6 changes: 6 additions & 0 deletions hsmd/libhsmd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,6 +547,7 @@ static void hsm_key_for_utxo(struct privkey *privkey, struct pubkey *pubkey,
* add a partial sig for each */
static void sign_our_inputs(struct utxo **utxos, struct wally_psbt *psbt)
{
bool is_cache_enabled = false;
for (size_t i = 0; i < tal_count(utxos); i++) {
struct utxo *utxo = utxos[i];
for (size_t j = 0; j < psbt->num_inputs; j++) {
Expand Down Expand Up @@ -584,6 +585,11 @@ static void sign_our_inputs(struct utxo **utxos, struct wally_psbt *psbt)
utxo->amount);
}
tal_wally_start();
if (!is_cache_enabled) {
/* Enable caching signature sub-hashes */
wally_psbt_signing_cache_enable(psbt, 0);
is_cache_enabled = true;
}
if (wally_psbt_sign(psbt, privkey.secret.data,
sizeof(privkey.secret.data),
EC_FLAG_GRIND_R) != WALLY_OK) {
Expand Down