Skip to content

Renepay too far #9324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cdecker merged 2 commits into from
Jul 18, 2026
+30 −4
Merged

Renepay too far #9324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d7ab83
renepay: add test to check for wrong CLTV computation
Lagrang3 Jul 17, 2026
449e81c
renepay: fix CLTV value for the first hop
Lagrang3 Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contrib/msggen/msggen/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24597,7 +24597,7 @@
"updated_index": 113,
"short_channel_id": "116x1x1",
"id": 11,
"expiry": 281,
"expiry": 143,
"direction": "out",
"amount_msat": 400000,
"payment_hash": "3fe5289854b8924b4ebb3f61cd8f5a29f8f509cc781919230f7ee95ec2fa7c46",
Expand Down
2 changes: 1 addition & 1 deletion doc/schemas/listhtlcs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@
"updated_index": 113,
"short_channel_id": "116x1x1",
"id": 11,
"expiry": 281,
"expiry": 143,
"direction": "out",
"amount_msat": 400000,
"payment_hash": "3fe5289854b8924b4ebb3f61cd8f5a29f8f509cc781919230f7ee95ec2fa7c46",
Expand Down
3 changes: 1 addition & 2 deletions plugins/renepay/routetracker.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,8 +449,7 @@ struct command_result *route_sendpay_request(struct command *cmd,
json_add_amount_msat(req->js, "amount_msat", hop->amount);
json_add_node_id(req->js, "id", &hop->node_id);
json_add_short_channel_id(req->js, "channel", hop->scid);
json_add_num(req->js, "delay",
hop->delay + payment->blockheight);
json_add_num(req->js, "delay", hop->delay);
json_object_end(req->js);

// FIXME: No localinvreqid is provided
Expand Down
27 changes: 27 additions & 0 deletions tests/test_renepay.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -874,3 +874,30 @@ def test_unannounced(node_factory):
b12 = l1.rpc.fetchinvoice(offer, "21sat")["invoice"]
ret = l1.rpc.call("renepay", {"invstring": b12})
assert ret["status"] == "complete"


def test_cltv_value(node_factory, bitcoind):
cltv_delta = 5
l1, l2, l3 = node_factory.line_graph(
3,
wait_for_announce=True,
opts={
"allow-deprecated-apis": True,
"cltv-delta": cltv_delta,
"fee-base": 0,
"fee-per-satoshi": 0,
},
)
blockheight = l1.rpc.waitblockheight(0)["blockheight"]
# BOLT-11 direct peer
b11 = l3.rpc.invoice(
"100sat", "test_renepay_expiry_too_far", "test_renepay_expiry_too_far"
)["bolt11"]
decoded_b11 = l1.rpc.decode(b11)
final_cltv = decoded_b11["min_final_cltv_expiry"]
ret = l1.rpc.call("renepay", {"invstring": b11})
assert ret["status"] == "complete"
pattern = r"Adding HTLC 0 amount=100000msat cltv=(\d+)"
line = l1.daemon.wait_for_log(pattern)
cltv = int(re.search(pattern, line).group(1))
assert cltv == (blockheight + 1) + cltv_delta + final_cltv
Loading