Fix check peer connection before connecting#525
Merged
Conversation
Add a ListPeers check at the start of ConnectToPeer to short-circuit when the peer is already connected, avoiding unnecessary ConnectPeer RPC calls and noisy errors. Also throw PeerNotOnlineException early when no TCP address is available for the peer, and reuse the macaroon metadata across both RPC calls. stack-info: PR: #525, branch: Jossec101/stack/11
Jossec101
force-pushed
the
Jossec101/stack/11
branch
from
a01e774 to
c61d73a
Compare
This was referenced Jun 30, 2026
markettes
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Fix check peer connection before connecting
Add a ListPeers check at the start of ConnectToPeer to short-circuit
when the peer is already connected, avoiding unnecessary ConnectPeer
RPC calls and noisy errors. Also throw PeerNotOnlineException early
when no TCP address is available for the peer, and reuse the macaroon
metadata across both RPC calls.