Enable dynamic fee management for new channels - #558
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables dynamic fee management by default on newly created/discovered channels, based on the managed node’s DynamicFeeManagementEnabled setting, so the routing fee engine can pick up eligible channels without manual per-channel toggling.
Changes:
- Set
Channel.IsDynamicFeeEnabledwhen persisting channels created viaLightningService.CreateChannel(...). - Set
Channel.IsDynamicFeeEnabledwhen persisting channels discovered viaNodeChannelSubscribeJobopen-channel events.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Services/LightningService.cs | Marks newly persisted channels as dynamic-fee-enabled based on the source node’s dynamic fee setting. |
| src/Jobs/NodeChannelSubscribeJob.cs | Marks newly discovered channels as dynamic-fee-enabled during channel open event handling. |
Suppressed comments (1)
src/Jobs/NodeChannelSubscribeJob.cs:129
- This change introduces new behavior (auto-setting
IsDynamicFeeEnabledon newly observed channels) but the existingNodeChannelSubscribeJobTestsdon’t assert anything about the dynamic-fee flag. Adding a test that captures the channel passed to_channelRepository.AddAsync(...)would prevent regressions, especially for the managed-node de-dup case.
IsPrivate = channelOpened.Private,
IsDynamicFeeEnabled = node.DynamicFeeManagementEnabled
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Jossec101
previously approved these changes
Aug 6, 2026
Jossec101
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce dynamic fee management for newly created channels when the node has dynamic fee enabled, allowing for more flexible fee handling based on node settings. This change enhances the channel creation and update processes to incorporate dynamic fee capabilities.