Re-enable hessian_dtype - #356
Merged
Merged
Conversation
hessian_dtype only reached the covariance collectors — the eigenvalue- correction pass ignored it and accumulated in the activations' dtype. Pass it to LambdaCollector in both the standard and per-checkpoint (SOURCE) paths, and add an fp64 option for kronfluence-parity precision studies.
luciaquirke
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LambdaCollectorgains adtypefield: eigenvectors are cast once at setup, activations/gradients at the hooks, so rotation + squared accumulation and the saved shards all run in the requested dtype.approximate_hessianspasseshessian_dtypeto both collector branches; the SOURCEprecompute_checkpointslambda worker does the same.fp64option forhessian_dtype(config Literal +convert_precision_to_torch).Tests
tests/ekfac_tests/test_hessian_dtype.py: pins the accumulation and saved-shard dtype through both collectors (fp64/fp16/fp32) and the fp64 conversion. Fulltests/ekfac_tests+tests/test_hessian.py: 76 passed, 4 skipped.